Skip to content

Call native animation callbacks only once - #3574

Merged
Alexander Sklar (asklar) merged 2 commits into
masterfrom
user/asklar/callbacks
Nov 1, 2019
Merged

Alexander Sklar (asklar) merged 2 commits into
masterfrom
user/asklar/callbacks

Conversation

@asklar

@asklar Alexander Sklar (asklar) commented Nov 1, 2019 •

Copy link
Copy Markdown
Member

After enabling native animations, Outlook is running into cases where a "finished animation" callback is called more than once. Looking at the code it's pretty clear this is because when stopping an animation, we call it with completed=false, and then try to mark the animation as completed but that function call tries to call the callback again with completed=true this time.

Fixes #2981

Microsoft Reviewers: Open in CodeFlow

@asklar
Alexander Sklar (asklar) requested a review from a team as a code owner November 1, 2019 06:58

@ddalp Di Da (ddalp) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@asklar
Alexander Sklar (asklar) merged commit 384358c into master Nov 1, 2019
@acoates-ms
acoates-ms deleted the user/asklar/callbacks branch December 6, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

startAnimatingNode() exists in NativeAnimatedModule, but only one callback may be registered to a function in a native module.

2 participants