You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We patched Yoga to change measurement behavior with microsoft/react-native-macos#100. This requires us to maintain a separate copy of Yoga in react-native-windows. We should upstream our patch into facebook/react-native.
acoates-ms was of the opinion we may want to put the change behind a preprocessor definition we would enable in RNW to avoid changing iOS/Android behavior.
Nick Gerleman (@NickGerleman) Hi, I just stumbled over that open issue. As I heavily contributed to https://github.com/facebook/yoga a few years ago, my recommendation would be to use YGExperimentalFeature* + YGConfigSetExperimentalFeatureEnabled for that, as it doesn't require a preprocessor. We actually added that behavior exactly for those cases.
You simply extend the sequence in YGEnum.h + adding the logic around that. You could then enable that behavior only for affected (sub-)trees.
It looks like microsoft/react-native-macos#100 patch was accidentally deleted in the 9/20/23 Integration (#12165). Yoga.cpp has since been deleted, so if this change is still needed, we will need to fork CalculateLayout.cpp.
Activity
woehrl01 commentedon May 27, 2020
Nick Gerleman (@NickGerleman) Hi, I just stumbled over that open issue. As I heavily contributed to https://github.com/facebook/yoga a few years ago, my recommendation would be to use
YGExperimentalFeature*+YGConfigSetExperimentalFeatureEnabledfor that, as it doesn't require a preprocessor. We actually added that behavior exactly for those cases.You simply extend the sequence in
YGEnum.h+ adding the logic around that. You could then enable that behavior only for affected (sub-)trees.marlenecota commentedon Jan 10, 2024
It looks like microsoft/react-native-macos#100 patch was accidentally deleted in the 9/20/23 Integration (#12165). Yoga.cpp has since been deleted, so if this change is still needed, we will need to fork CalculateLayout.cpp.