Skip to content

Upstream Yoga Measurement Patches #3994

Closed

Description

We patched Yoga to change measurement behavior with microsoft/react-native-macos#100. This requires us to maintain a separate copy of Yoga in react-native-windows. We should upstream our patch into facebook/react-native.

acoates-ms was of the opinion we may want to put the change behind a preprocessor definition we would enable in RNW to avoid changing iOS/Android behavior.

Activity

  1. ghost added
    Needs: Triage 🔍New issue that needs to be reviewed by the issue management team (label applied by bot)
    on Jan 30, 2020
  2. ghost added
    Invalid Triagehttps://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
    on Apr 9, 2020
  3. woehrl01 commented on May 27, 2020

    @woehrl01

    Nick Gerleman (@NickGerleman) Hi, I just stumbled over that open issue. As I heavily contributed to https://github.com/facebook/yoga a few years ago, my recommendation would be to use YGExperimentalFeature* + YGConfigSetExperimentalFeatureEnabled for that, as it doesn't require a preprocessor. We actually added that behavior exactly for those cases.

    You simply extend the sequence in YGEnum.h + adding the logic around that. You could then enable that behavior only for affected (sub-)trees.

  4. added and removed
    Invalid Triagehttps://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
    on Jul 17, 2020
  5. ghost added
    Invalid Triagehttps://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
    on Sep 16, 2020
  6. added and removed
    Invalid Triagehttps://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
    on Sep 25, 2020
  7. marlenecota commented on Jan 10, 2024

    @marlenecota
    Contributor

    It looks like microsoft/react-native-macos#100 patch was accidentally deleted in the 9/20/23 Integration (#12165). Yoga.cpp has since been deleted, so if this change is still needed, we will need to fork CalculateLayout.cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions