Repository navigation
fix(0.81, macos): Fabric accessibility roles and state, and TextInput read-only and Tab-stop fixes - #3189
Open
Jason Morse (JasonVMo) wants to merge 2 commits into
Open
fix(0.81, macos): Fabric accessibility roles and state, and TextInput read-only and Tab-stop fixes#3189Jason Morse (JasonVMo) wants to merge 2 commits into
Jason Morse (JasonVMo) wants to merge 2 commits into
Conversation
Backport the first-parent diff of 0b569f1 (#3136), including the final review fixes. Keep the two macOS RNTester accessibility examples without introducing the main-only aria-hidden example. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fe49cb92-f2e6-4bc2-89f0-d7d7a795c675
Keep the macOS example platform values in RNTesterPlatform rather than widening them to string on 0.81. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fe49cb92-f2e6-4bc2-89f0-d7d7a795c675
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Backports #3136 to
0.81-stable, including the final review fixes. This restores macOS Fabric accessibility roles and states, separates read-only TextInput from disabled TextInput, and makes each Fabric TextInput a single Tab stop.Resolved the RNTester conflict by carrying over only the two macOS examples. The native patch matches the landed PR. This branch predates Changesets. Paper and downstream validation remain tracked in #3135.
Test Plan:
git diff --cached --check— passed.yarn install --immutable— passed with peer-dependency warnings.yarn exec prettier --check packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js— passed.yarn exec eslint --max-warnings 0 packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js— passed.yarn flow-check --max-workers 4— could not run: this branch ships an x86_64 macOS Flow binary, which failed to launch on this arm64 host.yarn flow-checkon Linux CI — passed after explicitly typing the RNTester example array.RCT_NEW_ARCH_ENABLED=0 pod install(frompackages/rn-tester) — passed with CocoaPods 1.17.0.xcodebuild -workspace packages/rn-tester/RNTesterPods.xcworkspace -sdk macosx -configuration Debug -scheme RNTester-macOS -derivedDataPath packages/rn-tester/build -jobs 6 -quiet CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO build— passed with the Paper configuration.The npm publish dry-run fails because
node .ado/scripts/prepublish-check.mjs --verbose --skip-auth --tag latestexpects0.81-stable, but the unchanged basenx.jsonresolveslatest.Not run locally: the 0.81 Fabric, iOS or visionOS app builds; runtime accessibility and Tab order on Fabric or Paper; VoiceOver; or downstream FluentUI smoke tests.