Skip to content

fix(parser): allow in in array literals in a for statement initializer - #65330

Open
Jemmy (JemmyIndex) wants to merge 1 commit into
microsoft:mainfrom
JemmyIndex:fix/array-literal-in-for-init
Open

Jemmy (JemmyIndex) wants to merge 1 commit into
microsoft:mainfrom
JemmyIndex:fix/array-literal-in-for-init

Conversation

@JemmyIndex

@JemmyIndex Jemmy (JemmyIndex) commented Nov 5, 2026 •

Copy link
Copy Markdown

Fixes #65311.

The [~In] parameter of a for statement head does not reach into array literals — ElementList : AssignmentExpression[+In] — but parseArrayLiteralExpression parsed its elements in the caller's context, so the DisallowInContext flag set for a for initializer leaked into the element list:

const o = { a: 1 }, k = "a";
for (let i = 0, has = [k in o]; i < 1; i++) {} // TS1005: ',' expected.
let x: any;
for ([x = "x" in {}] of [[]]) {}               // TS1005: ',' expected.

The neighbouring productions already clear the flag — object literal property values (parseObjectLiteralExpression → doInContext(DisallowInContext, false, …)) and call arguments (parseArgumentExpression) — so this does the same for array literal elements. That also fixes the destructuring-assignment form in a for-of head, which test262 covers in language/statements/for-of/dstr/array-elem-init-in.js.

Only the tokens between [ and ] are affected: the flag is restored once the ] is consumed, so for (x in y) and for ([a, b] in y) parse exactly as before (and still report TS2491), and emit is unchanged.

Added tests/cases/compiler/arrayLiteralInOperatorInForInitializer.ts, covering a plain for initializer, comma and nested elements, an array pattern in a for-of head, and the unchanged for-in behavior.

Verification: go test ./internal/parser/... and the full go test ./internal/testrunner (compiler + conformance baselines) pass.

AI assistance

This PR was written with AI assistance, and the change is deliberately scoped to clearing the DisallowInContext flag while parsing array literal elements. I verified the behavior manually: both repros from the issue parse cleanly, for (x in y) and for ([a, b] in y) still report TS2491, and emit is unchanged. go test ./internal/parser/... and the full go test ./internal/testrunner pass locally. I understand the implementation and am happy to answer questions about it.

The [~In] of a for statement head does not reach into array literals (ElementList : AssignmentExpression[+In]), but parseArrayLiteralExpression parsed its elements in the caller's context, so the DisallowInContext flag leaked into the element list. Clear it the same way parseArgumentExpression and object literal property values already do.
Copilot AI balanced review requested due to automatic review settings November 5, 2026 06:54
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Nov 5, 2026
@typescript-automation typescript-automation Bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the parser change allowing in inside array literals in for initializers.

No open issues 🎉

What changed in this PR

Fixes #65311 by allowing the in operator inside array literals in for initializers, aligning the native TypeScript parser with JavaScript grammar.

Changes:

  • Clears DisallowInContext while parsing array elements, then restores the surrounding context.
  • Adds regression coverage for array expressions, for-of destructuring defaults, and ordinary for-in parsing.
  • Adds expected JavaScript, type, and symbol baselines.
File Description
tsc/​testdata/​tests/​cases/​compiler/​arrayLiteralInOperatorInForInitializer.ts Adds regression cases for in in loop-head arrays.
tsc/​testdata/​baselines/​reference/​compiler/​arrayLiteralInOperatorInForInitializer.types Records expected expression types.
tsc/​testdata/​baselines/​reference/​compiler/​arrayLiteralInOperatorInForInitializer.symbols Records expected symbol bindings.
tsc/​testdata/​baselines/​reference/​compiler/​arrayLiteralInOperatorInForInitializer.js Records expected JavaScript output.
tsc/​internal/​parser/​parser.go Allows in while parsing array literal elements.

Review effort: Balanced

@RyanCavanaugh

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test it

@typescript-automation

typescript-automation Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-automation

Copy link
Copy Markdown
Contributor

Hey Ryan Cavanaugh (@RyanCavanaugh), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-automation

Copy link
Copy Markdown
Contributor

Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the user tests with tsc comparing baseline and pr:

Everything looks good!

@typescript-automation

Copy link
Copy Markdown
Contributor

Ryan Cavanaugh (@RyanCavanaugh)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - native
Errors 41 41 ~ ~ ~ p=1.000 n=20
Symbols 88,466 88,466 ~ ~ ~ p=1.000 n=20
Types 79,607 79,607 ~ ~ ~ p=1.000 n=20
Memory Used 106,393k (± 0.02%) 106,423k (± 0.03%) ~ 106,282k 106,528k p=0.144 n=20
Memory Allocs 1,262,018 (± 0.01%) 1,261,927 (± 0.01%) ~ 1,261,491 1,262,191 p=0.280 n=20
Config Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Parse Time 0.022s (± 2.86%) 0.023s (± 3.10%) ~ 0.019s 0.025s p=0.358 n=20
Bind Time 0.008s (± 5.47%) 0.008s (± 4.78%) ~ 0.007s 0.010s p=0.957 n=20
Check Time 0.203s (± 0.73%) 0.203s (± 0.67%) ~ 0.199s 0.208s p=0.835 n=20
Emit Time 0.130s (± 0.96%) 0.129s (± 0.70%) ~ 0.125s 0.133s p=0.781 n=20
Total Time 0.366s (± 0.51%) 0.367s (± 0.37%) ~ 0.362s 0.373s p=0.548 n=20
angular-1 - native
Errors 63 63 ~ ~ ~ p=1.000 n=20
Symbols 756,637 756,637 ~ ~ ~ p=1.000 n=20
Types 549,451 549,451 ~ ~ ~ p=1.000 n=20
Memory Used 644,068k (± 0.02%) 644,053k (± 0.02%) ~ 643,516k 644,513k p=0.805 n=20
Memory Allocs 9,545,869 (± 0.09%) 9,546,216 (± 0.08%) ~ 9,532,107 9,584,935 p=0.678 n=20
Config Time 0.008s (± 1.77%) 0.008s ~ ~ ~ p=0.487 n=20
Parse Time 0.117s (± 1.96%) 0.117s (± 2.49%) ~ 0.106s 0.130s p=0.773 n=20
Bind Time 0.040s (±11.24%) 0.040s (± 9.16%) ~ 0.034s 0.059s p=0.326 n=20
Check Time 0.615s (± 1.07%) 0.614s (± 1.18%) ~ 0.587s 0.631s p=0.825 n=20
Emit Time 0.390s (± 0.93%) 0.391s (± 0.65%) ~ 0.383s 0.403s p=0.217 n=20
Total Time 1.182s (± 0.52%) 1.183s (± 0.59%) ~ 1.160s 1.212s p=0.815 n=20
arktype - native
Errors 0 0 ~ ~ ~ p=1.000 n=20
Symbols 686,116 686,116 ~ ~ ~ p=1.000 n=20
Types 939,797 939,797 ~ ~ ~ p=1.000 n=20
Memory Used 475,942k (± 0.01%) 476,013k (± 0.01%) ~ 475,809k 476,212k p=0.057 n=20
Memory Allocs 12,059,384 (± 0.02%) 12,058,554 (± 0.01%) ~ 12,055,021 12,065,615 p=0.565 n=20
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=20
Parse Time 0.042s (± 3.28%) 0.041s (± 2.79%) ~ 0.036s 0.047s p=0.269 n=20
Bind Time 0.014s (±10.83%) 0.012s (± 6.03%) ~ 0.011s 0.018s p=0.381 n=20
Check Time 0.831s (± 0.48%) 0.837s (± 0.71%) ~ 0.817s 0.864s p=0.095 n=20
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Total Time 0.915s (± 0.39%) 0.918s (± 0.66%) ~ 0.895s 0.945s p=0.365 n=20
class-transformer - native
Errors 0 0 ~ ~ ~ p=1.000 n=20
Symbols 45,376 45,376 ~ ~ ~ p=1.000 n=20
Types 7,573 7,573 ~ ~ ~ p=1.000 n=20
Memory Used 27,748k (± 0.03%) 27,749k (± 0.02%) ~ 27,731k 27,776k p=0.857 n=20
Memory Allocs 248,275 (± 0.07%) 248,335 (± 0.06%) ~ 247,947 249,335 p=0.805 n=20
Config Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Parse Time 0.011s (± 3.85%) 0.011s (± 2.80%) ~ 0.010s 0.012s p=1.000 n=20
Bind Time 0.004s (±10.39%) 0.004s (±13.12%) ~ 0.002s 0.005s p=0.690 n=20
Check Time 0.007s (± 7.42%) 0.007s (± 6.88%) ~ 0.006s 0.009s p=0.885 n=20
Emit Time 0.008s (± 7.15%) 0.008s (± 7.24%) ~ 0.006s 0.010s p=0.816 n=20
Total Time 0.031s (± 1.63%) 0.031s (± 2.09%) ~ 0.028s 0.033s p=0.915 n=20
effect - native
Errors 12 12 ~ ~ ~ p=1.000 n=20
Symbols 1,235,134 1,235,134 ~ ~ ~ p=1.000 n=20
Types 893,436 893,436 ~ ~ ~ p=1.000 n=20
Memory Used 941,660k (± 0.02%) 941,516k (± 0.02%) ~ 940,806k 942,220k p=0.277 n=20
Memory Allocs 12,626,413 (± 0.06%) 12,625,720 (± 0.04%) ~ 12,610,799 12,647,377 p=0.758 n=20
Config Time 0.002s 0.002s ~ ~ ~ p=1.000 n=20
Parse Time 0.148s (± 1.20%) 0.149s (± 2.36%) ~ 0.138s 0.169s p=1.000 n=20
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Check Time 0.861s (± 0.81%) 0.861s (± 0.74%) ~ 0.839s 0.885s p=0.984 n=20
Emit Time 0.485s (± 1.20%) 0.481s (± 1.17%) ~ 0.455s 0.506s p=0.245 n=20
Total Time 1.583s (± 0.42%) 1.583s (± 0.42%) ~ 1.559s 1.621s p=0.867 n=20
mui-docs - native
Errors 11,405 11,405 ~ ~ ~ p=1.000 n=20
Symbols 3,782,394 3,782,394 ~ ~ ~ p=1.000 n=20
Types 1,355,778 1,355,778 ~ ~ ~ p=1.000 n=20
Memory Used 1,678,768k (± 0.09%) 1,678,483k (± 0.09%) ~ 1,672,748k 1,685,181k p=0.947 n=20
Memory Allocs 25,761,228 (± 0.17%) 25,736,476 (± 0.12%) ~ 25,592,497 25,828,339 p=0.698 n=20
Config Time 0.009s (± 2.52%) 0.010s (±16.73%) ~ 0.008s 0.024s p=0.510 n=20
Parse Time 0.319s (± 3.00%) 0.319s (± 2.88%) ~ 0.287s 0.375s p=0.723 n=20
Bind Time 0.001s 0.001s ~ ~ ~ p=1.000 n=20
Check Time 3.192s (± 0.91%) 3.207s (± 1.28%) ~ 3.056s 3.381s p=0.507 n=20
Emit Time 0.275s (± 2.99%) 0.272s (± 1.65%) ~ 0.258s 0.296s p=0.825 n=20
Total Time 4.320s (± 0.75%) 4.342s (± 1.05%) ~ 4.135s 4.531s p=0.344 n=20
sentry - native
Errors 2 2 ~ ~ ~ p=1.000 n=20
Symbols 4,793,266 4,793,266 ~ ~ ~ p=1.000 n=20
Types 2,607,066 2,607,066 ~ ~ ~ p=1.000 n=20
Memory Used 2,798,859k (± 0.04%) 2,799,561k (± 0.04%) ~ 2,796,106k 2,805,303k p=0.327 n=20
Memory Allocs 75,084,252 (± 0.29%) 75,115,069 (± 0.22%) ~ 74,648,555 75,799,796 p=0.495 n=20
Config Time 0.025s (± 0.93%) 0.025s (± 1.11%) ~ 0.024s 0.026s p=1.000 n=20
Parse Time 0.464s (± 4.30%) 0.463s (± 3.76%) ~ 0.423s 0.593s p=0.888 n=20
Bind Time 0.159s (±10.97%) 0.148s (± 9.97%) ~ 0.123s 0.218s p=0.465 n=20
Check Time 6.473s (± 0.58%) 6.503s (± 0.50%) ~ 6.392s 6.624s p=0.144 n=20
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Total Time 7.172s (± 0.52%) 7.192s (± 0.55%) ~ 7.112s 7.466s p=0.525 n=20
social-app - native
Errors 0 0 ~ ~ ~ p=1.000 n=20
Symbols 1,883,060 1,883,060 ~ ~ ~ p=1.000 n=20
Types 1,158,093 1,158,093 ~ ~ ~ p=1.000 n=20
Memory Used 952,744k (± 0.02%) 952,807k (± 0.02%) ~ 951,929k 953,554k p=0.542 n=20
Memory Allocs 13,493,368 (± 0.12%) 13,524,708 (± 0.33%) ~ 13,447,866 13,802,559 p=0.529 n=20
Config Time 0.007s (± 3.00%) 0.007s (± 3.20%) ~ 0.007s 0.008s p=0.514 n=20
Parse Time 0.156s (± 2.72%) 0.154s (± 2.67%) ~ 0.137s 0.174s p=0.506 n=20
Bind Time 0.039s (± 7.75%) 0.041s (±10.57%) ~ 0.034s 0.069s p=0.052 n=20
Check Time 1.388s (± 1.12%) 1.400s (± 1.27%) ~ 1.337s 1.464s p=0.245 n=20
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Total Time 1.607s (± 0.95%) 1.622s (± 1.13%) ~ 1.562s 1.700s p=0.185 n=20
strada-build-src - native
Errors 0 0 ~ ~ ~ p=1.000 n=20
Symbols 1,184,972 1,184,972 ~ ~ ~ p=1.000 n=20
Types 438,823 438,823 ~ ~ ~ p=1.000 n=20
Memory Used 1,159,636k (± 0.32%) 1,165,366k (± 0.40%) ~ 1,150,762k 1,181,768k p=0.081 n=20
Memory Allocs 47,616,181 (± 0.12%) 47,675,714 (± 0.13%) ~ 47,420,041 47,838,825 p=0.142 n=20
Config Time 0.002s (±19.90%) 0.002s (±20.65%) ~ 0.001s 0.003s p=0.346 n=20
Parse Time 0.145s (± 2.63%) 0.143s (± 2.54%) ~ 0.131s 0.157s p=0.596 n=20
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Check Time 0.838s (± 1.10%) 0.842s (± 1.48%) ~ 0.812s 0.904s p=0.888 n=20
Emit Time 0.148s (± 2.20%) 0.153s (± 3.81%) ~ 0.139s 0.173s p=0.673 n=20
Total Time 9.811s (± 1.26%) 9.906s (± 1.65%) ~ 9.568s 10.791s p=0.478 n=20
strada-compiler - native
Errors 0 0 ~ ~ ~ p=1.000 n=20
Symbols 263,481 263,481 ~ ~ ~ p=1.000 n=20
Types 196,103 196,103 ~ ~ ~ p=1.000 n=20
Memory Used 221,498k (± 0.03%) 221,562k (± 0.02%) ~ 221,313k 221,723k p=0.101 n=20
Memory Allocs 2,388,396 (± 0.01%) 2,388,782 (± 0.01%) ~ 2,387,494 2,390,494 p=0.127 n=20
Config Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Parse Time 0.047s (± 3.92%) 0.047s (± 3.91%) ~ 0.043s 0.056s p=0.682 n=20
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Check Time 0.379s (± 0.85%) 0.377s (± 0.80%) ~ 0.365s 0.392s p=0.464 n=20
Emit Time 0.047s (± 5.11%) 0.050s (± 4.50%) ~ 0.041s 0.056s p=0.202 n=20
Total Time 0.502s (± 0.81%) 0.502s (± 0.59%) ~ 0.490s 0.516s p=0.743 n=20
t3code-server - native
Errors 0 0 ~ ~ ~ p=1.000 n=20
Symbols 4,349,937 4,349,937 ~ ~ ~ p=1.000 n=20
Types 3,042,465 3,042,465 ~ ~ ~ p=1.000 n=20
Memory Used 2,394,926k (± 0.02%) 2,395,495k (± 0.02%) ~ 2,394,208k 2,398,366k p=0.122 n=20
Memory Allocs 37,148,050 (± 0.08%) 37,144,725 (± 0.09%) ~ 37,068,787 37,369,167 p=0.758 n=20
Config Time 0.003s 0.003s ~ ~ ~ p=1.000 n=20
Parse Time 0.248s (± 2.90%) 0.259s (± 6.34%) ~ 0.231s 0.390s p=0.597 n=20
Bind Time 0.101s (±10.83%) 0.093s (±11.03%) ~ 0.074s 0.138s p=0.298 n=20
Check Time 5.981s (± 1.43%) 5.967s (± 0.70%) ~ 5.805s 6.128s p=0.888 n=20
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Total Time 6.346s (± 1.39%) 6.334s (± 0.88%) ~ 6.142s 6.669s p=0.888 n=20
tanstack-router - native
Errors 1 1 ~ ~ ~ p=1.000 n=20
Symbols 570,149 570,149 ~ ~ ~ p=1.000 n=20
Types 396,551 396,551 ~ ~ ~ p=1.000 n=20
Memory Used 315,324k (± 0.01%) 315,286k (± 0.02%) ~ 315,097k 315,476k p=0.265 n=20
Memory Allocs 4,327,102 (± 0.17%) 4,324,629 (± 0.10%) ~ 4,314,844 4,356,290 p=0.962 n=20
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=20
Parse Time 0.041s (± 3.72%) 0.040s (± 3.46%) ~ 0.035s 0.045s p=0.120 n=20
Bind Time 0.011s (± 5.48%) 0.011s (± 6.93%) ~ 0.010s 0.016s p=0.750 n=20
Check Time 0.458s (± 0.67%) 0.457s (± 0.79%) ~ 0.446s 0.475s p=0.357 n=20
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Total Time 0.528s (± 0.74%) 0.527s (± 0.87%) ~ 0.516s 0.552s p=0.498 n=20
ts-pre-modules - native
Errors 87 87 ~ ~ ~ p=1.000 n=20
Symbols 231,607 231,607 ~ ~ ~ p=1.000 n=20
Types 181,163 181,163 ~ ~ ~ p=1.000 n=20
Memory Used 190,855k (± 0.02%) 190,885k (± 0.02%) ~ 190,721k 191,010k p=0.176 n=20
Memory Allocs 1,309,997 (± 0.02%) 1,309,997 (± 0.02%) ~ 1,309,109 1,310,937 p=0.799 n=20
Config Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Parse Time 0.040s (± 2.90%) 0.040s (± 2.65%) ~ 0.036s 0.044s p=0.518 n=20
Bind Time 0.020s (± 6.32%) 0.020s (± 5.98%) ~ 0.016s 0.025s p=0.575 n=20
Check Time 0.295s (± 1.56%) 0.293s (± 1.05%) ~ 0.281s 0.305s p=0.973 n=20
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Total Time 0.362s (± 1.15%) 0.360s (± 0.75%) ~ 0.351s 0.373s p=0.931 n=20
vscode - native
Errors 11 11 ~ ~ ~ p=1.000 n=20
Symbols 7,856,949 7,856,949 ~ ~ ~ p=1.000 n=20
Types 4,598,905 4,598,905 ~ ~ ~ p=1.000 n=20
Memory Used 5,281,838k (± 0.01%) 5,282,251k (± 0.02%) ~ 5,279,264k 5,286,581k p=0.799 n=20
Memory Allocs 59,204,759 (± 0.02%) 59,207,337 (± 0.02%) ~ 59,179,502 59,281,808 p=0.883 n=20
Config Time 0.036s (± 3.44%) 0.037s (± 8.61%) ~ 0.034s 0.066s p=0.653 n=20
Parse Time 1.022s (± 2.70%) 1.019s (± 1.70%) ~ 0.969s 1.116s p=0.995 n=20
Bind Time 0.347s (± 7.59%) 0.337s (± 3.03%) ~ 0.313s 0.412s p=0.784 n=20
Check Time 7.790s (± 0.96%) 7.821s (± 0.64%) ~ 7.671s 8.021s p=0.763 n=20
Emit Time 2.168s (± 6.18%) 2.114s (± 3.42%) ~ 2.003s 2.555s p=0.963 n=20
Total Time 11.427s (± 1.18%) 11.390s (± 0.73%) ~ 11.203s 11.753s p=0.773 n=20
webpack - native
Errors 615 615 ~ ~ ~ p=1.000 n=20
Symbols 887,312 887,312 ~ ~ ~ p=1.000 n=20
Types 626,023 626,023 ~ ~ ~ p=1.000 n=20
Memory Used 647,555k (± 0.02%) 647,616k (± 0.02%) ~ 647,281k 648,071k p=0.351 n=20
Memory Allocs 6,067,947 (± 0.06%) 6,068,385 (± 0.06%) ~ 6,055,390 6,086,920 p=0.925 n=20
Config Time 0.004s 0.004s ~ ~ ~ p=1.000 n=20
Parse Time 0.124s (± 2.76%) 0.125s (± 1.43%) ~ 0.119s 0.133s p=0.408 n=20
Bind Time 0.038s (± 7.12%) 0.036s (± 2.70%) ~ 0.033s 0.041s p=0.167 n=20
Check Time 1.012s (± 1.23%) 1.015s (± 0.56%) ~ 0.992s 1.052s p=0.261 n=20
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Total Time 1.201s (± 1.06%) 1.201s (± 0.49%) ~ 1.179s 1.236s p=0.234 n=20
xstate-main - native
Errors 0 0 ~ ~ ~ p=1.000 n=20
Symbols 644,330 644,330 ~ ~ ~ p=1.000 n=20
Types 392,175 392,175 ~ ~ ~ p=1.000 n=20
Memory Used 347,005k (± 0.02%) 347,006k (± 0.02%) ~ 346,737k 347,357k p=0.941 n=20
Memory Allocs 3,997,542 (± 0.06%) 4,002,816 (± 0.08%) +5,274 (+ 0.13%) 3,993,293 4,018,679 p=0.010 n=20
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=20
Parse Time 0.059s (± 2.68%) 0.059s (± 1.94%) ~ 0.055s 0.063s p=0.731 n=20
Bind Time 0.020s (±11.19%) 0.019s (± 9.75%) ~ 0.016s 0.029s p=0.706 n=20
Check Time 0.415s (± 0.65%) 0.414s (± 0.67%) ~ 0.405s 0.426s p=0.448 n=20
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=20
Total Time 0.501s (± 0.80%) 0.498s (± 0.74%) ~ 0.486s 0.514s p=0.386 n=20
System info unknown
Hosts
  • native
Scenarios
  • Compiler-Unions - native
  • angular-1 - native
  • arktype - native
  • class-transformer - native
  • effect - native
  • mui-docs - native
  • sentry - native
  • social-app - native
  • strada-build-src - native
  • strada-compiler - native
  • t3code-server - native
  • tanstack-router - native
  • ts-pre-modules - native
  • vscode - native
  • webpack - native
  • xstate-main - native
Benchmark Name Iterations
Current pr 20
Baseline baseline 20

Developer Information:

Download Benchmarks

@typescript-automation

Copy link
Copy Markdown
Contributor

Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the top 400 repos with tsc comparing baseline and pr:

Everything looks good!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Not started

Development

Successfully merging this pull request may close these issues.

in inside an array literal in a for initializer is a syntax error (for (let i = 0, a = [k in o]; …))

3 participants