Repository navigation
brancher: add 'contest' check in case of failed gate checks (+ cleanup) - #133
Merged
Merged
Conversation
Simply by passing the description to send. So this code can be re-used elsewhere. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
To be reused above later, clearer like that. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
The logs are reporting when a series has missing or failing checks: clearer to put which one in the logs. This will also help a future commit only taking actions in case of failing checks. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
To allow being used in other context later on. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
When a series is skipped because somewhere in the series, some gate checks are failing, report that on PW to help the reviewers and authors understanding why the tests have not been started. Try to indicate where in the series, just to help a bit more just in case, and try to reduce PW requests to see if this has not already been set before. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
When a patch already has the 'contest' check about the failed gate checks, the series was added to the 'missing' list as a workaround, not to report the failure again. But that was misleading in the logs: the checks are not missing, they are failing. Instead, track the series where the failure has already been reported in a dedicated set: they are still skipped as failing, but without sending the same check again to PW. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Mostly not to use List and Tuple from typing, but the built-in types instead. Also remove an extra "list()" which is not needed, and the uuid import which is not used. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Member
Author
|
I suggest merging, I can fix stuff later on in case of issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, it was unclear why a PR didn't get tested. That's because a kdoc test was failing.
When a series is skipped because somewhere in the series, some gate checks are failing, report that on PW to help the reviewers and authors understanding why the tests have not been started.
Try to indicate where in the series, just to help a bit more just in case, and try to reduce PW requests to see if this has not already been set before.