Skip to content

create_invoice_from_channelmanager variant with description hash support #1280

Closed

Description

@TheBlueMatt

I'm not sure there's much use in description hashes in the wild today, except for lnurl/the lnpay stuff, which we'd of course like to support. We really need a variant of create_invoice_from_channelmanager which supports a description hash instead of explicit description for that, though, and will probably want something similar for create_phantom_invoice after #1199 is merged.

Tagging good first issue, but if someone does take this up, probably base it on #1199 or wait until that is merged.

Activity

  1. xraid commented on Jan 31, 2022

    @xraid

    no need for dh in lnurl one can use preimage_hash as id for what is described as dh in lnurl spec.

    it is just a handle for id in roundtrips

    dh is stupid . why have a description if it gets hashed and unreadable at recipient ?

  2. xraid commented on Jan 31, 2022

    @xraid

    a lnurl service could use a hash of the description not necessarily the bolt11 description_hash

  3. TheBlueMatt commented on Jan 31, 2022

    @TheBlueMatt
    CollaboratorAuthor

    No, the lnurl spec requires you use the description_hash in bolt 11, so to support lnurl you need this.

  4. xraid commented on Feb 1, 2022

    @xraid

    i used hash of preimige in a lnurl service . as it is only used as id in the roundtrip, where the service can id url and hash when incoming

  5. xraid commented on Feb 1, 2022

    @xraid

    You as service can put a teddybear in that field as long as You as service can id the teddybear when it comes back, it is not used by the client, only by service ...

  6. xraid commented on Feb 1, 2022

    @xraid

    maybe i am confusing it . lnurl-withdrawal can have teddybears in description_hash field, maybe lnurl-pay can not

  7. TheBlueMatt commented on Feb 1, 2022

    @TheBlueMatt
    CollaboratorAuthor

    Ah, yes, I was referring to lnurl-pay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions