You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
create_invoice_from_channelmanager variant with description hash support #1280
I'm not sure there's much use in description hashes in the wild today, except for lnurl/the lnpay stuff, which we'd of course like to support. We really need a variant of create_invoice_from_channelmanager which supports a description hash instead of explicit description for that, though, and will probably want something similar for create_phantom_invoice after #1199 is merged.
Tagging good first issue, but if someone does take this up, probably base it on #1199 or wait until that is merged.
You as service can put a teddybear in that field as long as You as service can id the teddybear when it comes back, it is not used by the client, only by service ...
Activity
xraid commentedon Jan 31, 2022
no need for dh in lnurl one can use preimage_hash as id for what is described as dh in lnurl spec.
it is just a handle for id in roundtrips
dh is stupid . why have a description if it gets hashed and unreadable at recipient ?
xraid commentedon Jan 31, 2022
a lnurl service could use a hash of the description not necessarily the bolt11 description_hash
TheBlueMatt commentedon Jan 31, 2022
No, the lnurl spec requires you use the description_hash in bolt 11, so to support lnurl you need this.
xraid commentedon Feb 1, 2022
i used hash of preimige in a lnurl service . as it is only used as id in the roundtrip, where the service can id url and hash when incoming
xraid commentedon Feb 1, 2022
You as service can put a teddybear in that field as long as You as service can id the teddybear when it comes back, it is not used by the client, only by service ...
xraid commentedon Feb 1, 2022
maybe i am confusing it . lnurl-withdrawal can have teddybears in description_hash field, maybe lnurl-pay can not
TheBlueMatt commentedon Feb 1, 2022
Ah, yes, I was referring to lnurl-pay.