You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug] Modal hardcodes aria-labelledby and aria-describedby pointing to nonexistent element IDs #1864
The rendered title element (<Typography data-testid="modal-title">{title}</Typography>) does not carry id="alert-dialog-slide-title".
There is no element rendered with id="alert-dialog-slide-description".
Because these IDs are static strings rather than dynamically generated (e.g., via React.useId()), any future attempt to attach static IDs would also produce duplicate-ID DOM collisions when multiple modals exist in the component tree.
Screen readers and automated accessibility audits (e.g., axe, Lighthouse) flag aria-labelledby and aria-describedby referencing nonexistent element IDs.
Currently, consumers must rely on conditional mounting ({isOpen && <Modal ... />}) as a workaround to avoid tree-level accessibility collisions.
Expected Behavior
aria-labelledby should reference the ID of the modal's rendered title component.
The ID should be unique per modal instance (using React.useId() or an overridable id / aria-labelledby prop) so multiple dialogs do not collide in the DOM.
If no description element is rendered, aria-describedby should not be attached by default unless explicitly supplied by consumer props.
Activity
docs: link modal a11y issue layer5io#1864 and clarify theme.shape.bor…
github-actions commentedon Oct 10, 2026
This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.
fix(Modal): keep aria-label off the dialog root; tighten tests and ty…
test(Modal): pin accessible-name precedence and document props (layer…
test(Modal): enforce accessible-name contract via tsc fixture (layer5…
fix(Modal): harden blank-title behavior, ARIA precedence, and control…
fix(Modal): enforce fail-closed useModal, injective title ID encoding…
refactor(Modal): minimize diff, eliminate ID collisions via useId, an…
refactor(Modal): revert out-of-scope runtime changes (layer5io#1864)
fix(Modal): normalize title presence, enforce ARIA precedence, and te…
fix(Modal): align precedence docs with behavior and tighten tests (la…
fix(Modal): align ARIA precedence docs and tests (layer5io#1864)
fix(Modal): enforce accessible naming for blank titles (layer5io#1864)
fix(Modal): preserve paper callback ownerState and support ARIA white…
fix(Modal): suppress backdrop on unnamed paper callback and simplify …
docs: link modal a11y issue layer5io#1864 and clarify theme.shape.bor…
revert(Modal): restore approved implementation and drop fail-closed b…
fix(Modal): treat whitespace ARIA strings as empty in mergePaperAttri…
fix(Modal): dynamically wire unique aria-labelledby and enforce acces…
test(Modal): add accessible name type checks and runtime regression t…
docs(Modal): document dynamic title IDs and accessible name precedenc…
fix(Modal): preserve PaperProps fallback and consolidate accessibilit…