Skip to content

columns: a corrupt parent state is re-read once per sidecar of a group since #788 met #754 #839

Open

Description

@MegaRedHand

Problem. Merging main into #788 put the PR's "a failed parent-state read drops the sidecar" rule inside main's grouped column prechecks (#754). There, ChainPrechecks::judge_header (crates/blockchain/state_transition/src/beacon/gossip/column.rs) does not remember an Err from get_state. That is deliberate, so that one transient read error does not drop the whole block: the group's next sidecar reads the state again.

For a corrupt parent state, though, every one of those reads fails. A group then re-reads it once per sidecar, one after another on the group's permit, up to the block's 128 columns. Each attempt is a full failed rebuild (about a second of CPU, by the StateRebuilds doc in crates/storage/src/state_writer.rs) plus an error! line. That works against #788's own rule that a corrupt root is read once and shared (Error::CorruptState). Verdicts are unaffected: every sidecar is dropped as Ignore(Internal) either way. Only on-disk corruption triggers it.

A related doc gap: the lean_data_columns_rejected_total section of docs/metrics.md still says reason="internal" counts the sidecars that a panic in the checks cost. Since the merge, it also counts sidecars dropped for a failed parent-state read.

Why it is a follow-up. #788 is approved and in the merge queue. The re-read only costs CPU on a node whose store is already corrupt.

Fix.

  • In judge_header, remember the drop for the block's parent when the error is ethlambda_storage::Error::CorruptState, so the rest of the group is dropped without reading again. Keep reading again on any other Err.
  • Add a test: a corrupt parent state is read once for a multi-sidecar group.
  • Add the failed-read case to the reason="internal" text in docs/metrics.md.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions