Skip to content

Add a --log-level flag instead of configuring logs through RUST_LOG only #821

Open

Description

@MegaRedHand

Summary

Log verbosity can only be set through RUST_LOG (init_node_logging and node_log_filter, bin/ethlambda/src/main.rs). The default is info, with libp2p_gossipsub capped at error. None of beacon, node or validator takes a log-level flag, so the setting doesn't show up in --help.

Where it shows up

ethereum-package passes Lighthouse (--debug-level), Teku (--logging), Lodestar (--logLevel), Nimbus (--log-level) and Prysm (--verbosity) their log level as a flag. For ethlambda, the launchers in ethpandaops/ethereum-package#1515 set RUST_LOG in the container environment instead. The same goes for docker-compose files, systemd units and anything else that only builds a command line.

Proposal

--log-level <error|warn|info|debug|trace> on all three sub-commands, setting the floor that node_log_filter currently hard-codes as info. RUST_LOG keeps working for per-target directives on top of it, and the gossipsub cap stays unless a directive names that target, as it does now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions