Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes text conditioning leakage in SDXL InstructPix2Pix training. When a prompt was dropped,
encoder_hidden_stateswas replaced with empty-prompt conditioning, butadd_text_embedsstill contained the original prompt's pooled embedding.This change also replaces the pooled embedding with the second text encoder's empty-prompt output, using the same dropout mask.
Validation
Added a regression test using tiny, real SDXL components and local synthetic data:
Both cases pass with the fix. The full-dropout case fails on the original code.
Lint, formatting, and
check_ai.pypassed.make styleandmake fix-copiespassed in an isolated snapshot. GPU training was not tested.AI-assisted self-review
Reviewed against the repository guidelines. No blocking findings or dead code were identified, and no findings were intentionally left unresolved.