Repository navigation
Raise a SetFileCompletionNotificationModes failure with its reason - #648
Merged
Merged
Conversation
It was a userError without the code. It is a Win32 error, not a Winsock one, so failIfFalse_ raises it with its message; the location says whether socket or accept was preparing the socket. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kazu-yamamoto
added a commit
that referenced
this pull request
Nov 15, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Left over from #639: when
SetFileCompletionNotificationModesfailed while associating a socket with the I/O manager,associateSocketraiseduserError "associateSocket: SetFileCompletionNotificationModes failed", without the error code.throwSocketErrorCode(which looks codes up in the Winsock table) would describe it as an unknown WinSock error.failIfFalse_fromWin32, already a dependency on Windows, raises it with the system's message for the code.Network.Socket.socketorNetwork.Socket.acceptwas preparing the socket, for this error and for the one from making it non-blocking.The failure is not expected for ordinary sockets; it is the error a socket behind a non-IFS LSP, which is not supported (#642), would most likely meet, so its reason is worth having. It cannot be provoked in a test.
Tested on Windows 11 with GHC 9.12.4.20260713: 124 examples, 0 failures, no new warnings.
🤖 Generated with Claude Code