Repository navigation
fix: [AH-6078]: reject unknown migrate config keys, apply PUPPET/DEBIAN patterns, warn on CONDA date filters - #411
Open
sameeksha-harness wants to merge 3 commits into
Conversation
…AN patterns, warn on CONDA date filters
jatin-agrawal-harness
approved these changes
Nov 5, 2026
jatin-agrawal-harness
approved these changes
Nov 5, 2026
Collaborator
|
cosmos review |
| default: | ||
| return false | ||
| } | ||
| return types.IsPackageLevelPatternFilterable(artifactType) |
Contributor
There was a problem hiding this comment.
Enabling the DEBIAN package-level path makes FilterFilesByPatternsPackageName match against pkg.Name, but extractDebianPackages and extractDebianSourcePackages populate that field with archive basenames such as nginx_1.24.0-1_amd64.deb and nginx_1.24.0-1.dsc, not the Debian package name. Consequently, includePatterns: [nginx] now silently migrates nothing, while excludePatterns: [nginx] leaves every nginx version eligible, contrary to the documented package-name filtering.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
Collaborator
|
cosmos review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 2 issues in migrate command listed below:
unknown config keys are silently accepted. A misspelled key in the migration config, such as includePattern instead of includePatterns, was ignored, so a narrowed migration turned into a migrate-everything run. Include/exclude patterns on PUPPET and DEBIAN were also accepted by validation but then ignored by the engine.
date filters can under-migrate index-seeded types. With a dateFilter, CONDA finds packages through repodata.json, which the date filter can drop. In-range packages can then be missed while the run still reports success.