Repository navigation
Conversation
jnewbery
left a comment
There was a problem hiding this comment.
Looks great. A few comments inline.
| display: block; | ||
| margin-left: auto; | ||
| margin-right: auto; | ||
| border:1px solid #e8e8e8; |
There was a problem hiding this comment.
I'm not sure about this border. Might look better without.
| @@ -1,3 +1,5 @@ | |||
| {:.third-party-logo} | |||
There was a problem hiding this comment.
Do we definitely need the wallet name if we have the logo? For example, if I look at the Abra page, it looks a bit messy to have the name in the top left, then the logo (which is the name in stylized text) in the center, and then back to the left for the description.
| @@ -1,3 +1,5 @@ | |||
| {:.third-party-logo} | |||
There was a problem hiding this comment.
Can you add a title attribute to the img, so that there's a tooltip when you hover over it?
| @@ -1,3 +1,5 @@ | |||
| {:.third-party-logo} | |||
There was a problem hiding this comment.
Question: should clicking on the image take you to that wallet/service's website? Or should we include a URL in this page?
There was a problem hiding this comment.
Bitcoin Core is the fully-worked example page, and for that I had previously linked the name of the wallet in the paragraph that introduces it. I think that's the best place because it's visually obvious that it's a link. Let me know if that's satisfactory, or I can also add a link to the image easily.
| @@ -1,3 +1,5 @@ | |||
| {:.third-party-logo} | |||
There was a problem hiding this comment.
Should the description be italicized and centered?
There was a problem hiding this comment.
I like it better the current way, but I've no strong opinion here.
| {% when "false" %}{:.feature-bad} | ||
| - **Doesn't show replacement transactions**<br> | ||
| FIXME | ||
| - **Received transaction labeled replaceable in transaction details**<br> |
| - **Signals BIP125 by default**<br> | ||
| FIXME | ||
| - **Allows sending RBF transactions**<br> | ||
| Allows sending of RBF transactions in the interface |
There was a problem hiding this comment.
I think this description should explicitly mention BIP125 signaling eg "Allows sending of transactions which signal that they are BIP 125 replaceable" or similar
| {% when "false" %}{:.feature-bad} | ||
| - **Doesn't show replacement transactions**<br> | ||
| FIXME | ||
| - **Received transaction labeled replaceable in transaction details**<br> |
There was a problem hiding this comment.
Should say "Sent transaction not labeled replaceable"
Compatability: many style edits based on jnewbery feedback
|
@bitschmidty do you want me to merge this even though it's labeled WIP? |
|
@harding Yes. I just renamed for accuracy as well. |
* translation of bitcoinops#206 * Update 2022-06-29-newsletter.md - Change “主动支付” to “要约” in #6 - Typo fixed in #7 (cherry picked from commit 7b19e4f) Co-authored-by: winky <zhaowenqibupt@gmail.com> Co-authored-by: freeyao <johnyao1526@gmail.com>
* translation of bitcoinops#206 * Update 2022-06-29-newsletter.md - Change “主动支付” to “要约” in #6 - Typo fixed in #7 (cherry picked from commit 7b19e4f) Co-authored-by: winky <zhaowenqibupt@gmail.com> Co-authored-by: freeyao <johnyao1526@gmail.com>

Remaining item is description of the service/wallet. I dont think that is a blocker for initial launch. Once the team reviews this PR as is, we can see if the descriptions are ready.