Skip to content

Compatibility rbf data - #6

Merged
harding merged 8 commits into
harding:2019-02-compatibilty-pocfrom
bitschmidty:compatibility-rbf-data
May 2, 2019
Merged

harding merged 8 commits into
harding:2019-02-compatibilty-pocfrom
bitschmidty:compatibility-rbf-data

Conversation

@bitschmidty

Copy link
Copy Markdown
Collaborator
  • added 3rd party logos
  • sorted alpha on list page
  • updated RBF testing descriptions
  • added ability to link to individual tests from the matrix

Remaining item is description of the service/wallet. I dont think that is a blocker for initial launch. Once the team reviews this PR as is, we can see if the descriptions are ready.

@bitschmidty
bitschmidty requested a review from harding April 10, 2019 16:13

@jnewbery jnewbery left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A few comments inline.

Comment thread assets/css/main.scss Outdated
display: block;
margin-left: auto;
margin-right: auto;
border:1px solid #e8e8e8;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this border. Might look better without.

@@ -1,3 +1,5 @@
![{{tool.name|escape_once}}]({{tool.logo}}){:.third-party-logo}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we definitely need the wallet name if we have the logo? For example, if I look at the Abra page, it looks a bit messy to have the name in the top left, then the logo (which is the name in stylized text) in the center, and then back to the left for the description.

@@ -1,3 +1,5 @@
![{{tool.name|escape_once}}]({{tool.logo}}){:.third-party-logo}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a title attribute to the img, so that there's a tooltip when you hover over it?

@@ -1,3 +1,5 @@
![{{tool.name|escape_once}}]({{tool.logo}}){:.third-party-logo}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: should clicking on the image take you to that wallet/service's website? Or should we include a URL in this page?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitcoin Core is the fully-worked example page, and for that I had previously linked the name of the wallet in the paragraph that introduces it. I think that's the best place because it's visually obvious that it's a link. Let me know if that's satisfactory, or I can also add a link to the image easily.

2019-04-24-16_10_32_819836136

@@ -1,3 +1,5 @@
![{{tool.name|escape_once}}]({{tool.logo}}){:.third-party-logo}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the description be italicized and centered?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it better the current way, but I've no strong opinion here.

{% when "false" %}{:.feature-bad}
- **Doesn't show replacement transactions**<br>
FIXME
- **Received transaction labeled replaceable in transaction details**<br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should say "not labeled"

- **Signals BIP125 by default**<br>
FIXME
- **Allows sending RBF transactions**<br>
Allows sending of RBF transactions in the interface

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this description should explicitly mention BIP125 signaling eg "Allows sending of transactions which signal that they are BIP 125 replaceable" or similar

{% when "false" %}{:.feature-bad}
- **Doesn't show replacement transactions**<br>
FIXME
- **Received transaction labeled replaceable in transaction details**<br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say "Sent transaction not labeled replaceable"

@harding

harding commented May 1, 2019

Copy link
Copy Markdown
Owner

@bitschmidty do you want me to merge this even though it's labeled WIP?

@bitschmidty bitschmidty changed the title WIP: Compatibility rbf data Compatibility rbf data May 2, 2019
@bitschmidty

Copy link
Copy Markdown
Collaborator Author

@harding Yes. I just renamed for accuracy as well.

@harding
harding merged commit 0ecd9d0 into harding:2019-02-compatibilty-poc May 2, 2019
harding pushed a commit that referenced this pull request Jul 11, 2022
* translation of bitcoinops#206

* Update 2022-06-29-newsletter.md

- Change “主动支付” to “要约” in #6
- Typo fixed in #7

(cherry picked from commit 7b19e4f)

Co-authored-by: winky <zhaowenqibupt@gmail.com>
Co-authored-by: freeyao <johnyao1526@gmail.com>
harding pushed a commit that referenced this pull request Sep 27, 2024
* translation of bitcoinops#206

* Update 2022-06-29-newsletter.md

- Change “主动支付” to “要约” in #6
- Typo fixed in #7

(cherry picked from commit 7b19e4f)

Co-authored-by: winky <zhaowenqibupt@gmail.com>
Co-authored-by: freeyao <johnyao1526@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants