Repository navigation
News 212: add review club summary - #24
Conversation
bitschmidty
left a comment
There was a problem hiding this comment.
Pushed a small commit fixing the numbering which was causing the last question to not render on the page.
Also pushed a link fix for the argsmanager link (quotes were missing so the link didn’t show)
Left a couple suggestions for the review club log links as well. I prefer linking to the question in the logs personally, but not a deal breaker.
I think that potentially adding a 4th question (maybe: In your own words, what are the validation caches? Why would they belong in src/kernel vs src/node?) could be valuable as well.
|
@LarryRuane Thanks for authoring the PR Review Club section this week! |
glozow
left a comment
There was a problem hiding this comment.
Good start! My main feedback is to remember to summarize the meeting rather than the notes/questions.
6c42c58 to
2722af8
Compare
|
Force-pushed to accept all review suggestions |
2722af8 to
0a67c04
Compare
|
Force-pushed to rebase |
Add review club section (https://bitcoincore.reviews/25527).
I'm new to this, so any feedback and corrections are very welcome!