Skip to content

News 212: add review club summary - #24

Merged
bitschmidty merged 1 commit into
harding:2022-08-10-newsletterfrom
LarryRuane:2022-08-10-212
Aug 9, 2022
Merged

bitschmidty merged 1 commit into
harding:2022-08-10-newsletterfrom
LarryRuane:2022-08-10-212

Conversation

@LarryRuane

Copy link
Copy Markdown

Add review club section (https://bitcoincore.reviews/25527).

I'm new to this, so any feedback and corrections are very welcome!

@bitschmidty bitschmidty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a small commit fixing the numbering which was causing the last question to not render on the page.

Also pushed a link fix for the argsmanager link (quotes were missing so the link didn’t show)

Left a couple suggestions for the review club log links as well. I prefer linking to the question in the logs personally, but not a deal breaker.

I think that potentially adding a 4th question (maybe: In your own words, what are the validation caches? Why would they belong in src/kernel vs src/node?) could be valuable as well.

@bitschmidty

Copy link
Copy Markdown
Collaborator

@LarryRuane Thanks for authoring the PR Review Club section this week!

@glozow glozow left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! My main feedback is to remember to summarize the meeting rather than the notes/questions.

@LarryRuane

Copy link
Copy Markdown
Author

Force-pushed to accept all review suggestions

@LarryRuane

Copy link
Copy Markdown
Author

Force-pushed to rebase

@bitschmidty
bitschmidty merged commit 1e0d361 into harding:2022-08-10-newsletter Aug 9, 2022
@LarryRuane
LarryRuane deleted the 2022-08-10-212 branch August 9, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants