Repository navigation
Add spellcheck CI to repository #5609
Description
There are tons of typos and spelling errors in our codebase, some are in the code and some are in the comments. As grpc-java is becoming more and more popular, maybe it's time to clean them up and have a required CI task running spellchecking on PRs. It might add some pain when creating PRs, but fixing typos in a single PR should not be too headache and it does things good to us. Envoy's repo is doing very well on this, maybe we could borrow what they are using.
Activity
[-]Add spellcheck CI to codebase[/-][+]Add spellcheck CI to repository[/+]sf7h commentedon Mar 20, 2020
Hi! would like to work on this - is it still up for grabs?
voidzcy commentedon Mar 20, 2020
@fathalls Thanks for being interested in this. Sure, you can have a try. Note the existing codebase already has tons of typos, so we may want the tool to just check for future PRs.
sf7h commentedon Mar 26, 2020
@voidzcy Should we add a pre-commit hook running a script to check the spelling or add a stage as part of Travis CI to check spelling on PRs?
IMHO First option could be better since it allows the developer to correct the misspellings before a branch is pushed.
Thoughts?
voidzcy commentedon Mar 26, 2020
Yeah, the first one sounds good.