Skip to content

OkHttpTransportTest earlyServerClose_serverFailure_withClientCancelOnListenerClosed is flaky #5181

Open

Description

@sanjaypujare

Please answer these questions before submitting your issue.

What version of gRPC are you using?

latest -> SNAPSHOT

What did you expect to see?

All tests should pass. Instead I see this failure more than once and it seems to be a flaky test:

Task :grpc-okhttp:test
io.grpc.okhttp.OkHttpTransportTest > earlyServerClose_serverFailure_withClientCancelOnListenerClosed FAILED
java.lang.AssertionError: Timed out waiting for server stream

build output:
https://source.cloud.google.com/results/invocations/3bc8b484-55e9-4e11-9476-c481f3dc1661/targets/grpc%2Fjava%2Fpresubmit%2Fmacos/log

Activity

  1. changed the title [-]Flaky test needs to be fixed or removed[/-] [+]OkHttpTransportTest earlyServerClose_serverFailure_withClientCancelOnListenerClosed is flaky[/+] on Dec 19, 2018
  2. added this to the Unscheduled milestone on Dec 19, 2018
  3. ejona86 commented on Dec 19, 2018

    @ejona86
    Member

    https://source.cloud.google.com/results/invocations/e3f8fd48-5ff4-40c8-b457-532aca2f6f16 (macos)

    io.grpc.okhttp.OkHttpTransportTest > earlyServerClose_serverFailure_withClientCancelOnListenerClosed FAILED
        java.lang.AssertionError: Timed out waiting for server stream
    
  4. ejona86 commented on Dec 19, 2018

    @ejona86
    Member

    The failure seems to be in takeListenerOrFail. There doesn't look to be anything special about this test. All the TransportTests do basically the same boilerplate. The test is failing after 1 second.

  5. ejona86 commented on Dec 19, 2018

    @ejona86
    Member

    Oh, wait. Not takeListenerOrFail(), but takeStreamOrFail(). This may be a legitimate failure, since that test was added because of a race in InProcess transport. Maybe OkHttp has the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions