Skip to content

Proposal: Remove mutable / immutable handler registry distinction #4600

Open

Description

@carl-mastrangelo

I'd like to float the idea of removing the mutable / immutable service registry distinction on io.grpc.Server, as I feel it is an unnecessary distinction. As far as I can tell, the sole purpose was a performance concern, but this shouldn't have bearing on the API surface. The methods to get it are Experimental, and only seem to be used for reflection. I believe reflection can still be efficient without knowing the difference.

This is not the same as the "fallback" registry, which is stable API, and IMO is a better distinction than mutable / immutable.

Thoughts @ejona86 ?

Activity

  1. ejona86 commented on Jun 29, 2018

    @ejona86
    Member

    @carl-mastrangelo, what precisely are you referring to? Are you suggesting removing Server.getMutableServices() and Server.getImmutableServices() and replacing them with a method that returns both in a single list?

  2. carl-mastrangelo commented on Jun 29, 2018

    @carl-mastrangelo
    ContributorAuthor

    The methods to remove are the ones on Server, the replacement is already on the class: Server.getServices()

  3. self-assigned this
    on Jul 31, 2018
  4. added this to the Unscheduled milestone on Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions