Repository navigation
Store updates: log event source of removal operations and make string formatting of block hashes consistent - #559
Merged
Conversation
fordN
force-pushed
the
ford/delete-logging-and-hash-string-formatting
branch
from
November 7, 2018 06:47
e3a99cb to
b26c607
Compare
timmclean
approved these changes
Nov 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
set_config()to set a run-time configuration parameter,current_event_source, without it thelog_deletetrigger procedure cannot track the event source.Revert operations were failing because block hashes were being stored in the db with differing formats, now all store operations convert the block hash to string using
hash_hex().