Repository navigation
Conversation
Extends `anneal-rustc-capture` (schema version 4 -> 5) to extract and
render Tier 2 structs, payload and niche-tagged enums, fixed-length
arrays, `Downcast`/`Index`/`ConstantIndex` projections, `Aggregate` /
`Repeat` / `SetDiscriminant`, `BoundsCheck` assertions, Tier 2 core
builtins (`checked_{add,sub,mul}`, `{to,from}_le_bytes`), and a closed
sysroot allowlist for `core::num::<impl {u,i}...>::{MIN,MAX,BITS}`.
Adds foundation-only (`propext`, `Quot.sound`) `range_add_sound` lemmas
to `Anneal.BitVec` and end-to-end Tier 2 verification fixtures covering
whole-crate `U64Range::{new,max,add_range,mul_range}` and selected-unit
`make_identity` totality and injectivity (with negative mutation tests).
Agent-authored-by: AI agent acting on joshlf's behalf
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## joshlf-anneal-p2-t2a-adts #4007 +/- ##
==========================================================
Coverage 92.99% 92.99%
==========================================================
Files 16 16
Lines 2469 2469
==========================================================
Hits 2296 2296
Misses 173 173 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human review surface
anneal/trusted/rustc-capture/src/{ir,extract,lean,capture}.rsandanneal/trusted/cargo-anneal/src/verify.rs:Bumps the typed capture schema (
4 -> 5) and extracts/renders Tier 2StructTy, payloadEnumTy(variant_fields,SingleandNichetaglayouts validated against
enumAdmittedCore), fixed-lengthArraytypes,ProjectionElem::{Downcast,Index,ConstantIndex},AggregateKind::{Tuple,AdtStruct,AdtEnum,Array},Rvalue::{Aggregate,Repeat},Statement::SetDiscriminant,AssertKind::BoundsCheck(usingrustc_hir::LangItem::PanicBoundsCheck),CoreBuiltin::{CheckedAdd,CheckedSub,CheckedMul,ToLeBytes,FromLeBytes},mir::Const::Tyscalar values (emitted byrustcfor array lengths inBoundsCheck), and a closed sysroot allowlist forcore::num::<impl {u,i}{8,16,32,64,128,size}>::{MIN,MAX,BITS}. Whole-cratescope now admits non-generic structs, payload enums, and non-generic inherent
implblocks while continuing to fail closed on crate-localconst/AnonConst,union,Drop, generic ADTs, and unmodeled types.anneal/theory/Anneal/BitVec.leanandanneal/trusted/cargo-anneal/src/bundled_resources.rs:Adds foundation-only (
propext,Quot.sound)range_add_both_overflow_soundand
range_add_soundlemmas and updates the regenerated bundled resources.anneal/trusted/rustc-capture/tests/typed_capture.rs,anneal/trusted/cargo-anneal/tests/{mvp_e2e,integration}.rs, andanneal/trusted/cargo-anneal/tests/fixtures/:Adds Tier 2 capture tests (
44/44), updates legacy Tier 1 struct/payload-enumfixture expectations to verify payload enums and
Wrapperstructs end-to-endwhile pinning
Union/unreachable_unchecked/anneal:invariantrefusals,and adds live
mvp_e2eTier 2 verification milestones (tier2_u64_rangeandtier2_make_identity, each with negative mutation checks).Summary
anneal-rustc-captureTier 2 extraction and Lean rendering atop#3999(T2a) in PR stack#3976.#![no_std]milestones undercargo-anneal(
linux_bwrap,exactType: true,replay: true,taint_reasons: [],axioms=["propext","Quot.sound"]):U64Range::{new, max, add_range, mul_range}(structs, inherentmethods,
u64::MAX,overflowing_add,checked_mul->Option<u64>,Discriminant,Downcast, andAnneal.BitVecrange soundness).make_identity(length: u32, level: u64, offset: u64) -> [u8; 12](
to_le_bytes,ConstantIndexarray destructuring, 12-byte arrayaggregate, totality, and 8192-byte-aligned injectivity via
Anneal.BitVec+Anneal.LeBytes).Verification
[kernel-checked proof]anneal-audit --require-correspondence: PASSdeclarations, 6906 total replayed declarations,
axioms=["propext","Quot.sound"].38728replayed declarations),Correspondence
3638replayed declarations /19453reachabledeclarations,
axioms=["propext","Classical.choice","Quot.sound"].[real measurement]regenerate_bundle --check: PASS.[real measurement]anneal-rustc-capture:22/22unit,23/23compiler_session,44/44typed_capture,clippy --all-targets -- -D warnings.[real measurement]cargo-anneal:52/52--lib,52/52--no-default-features --lib,14/14cli,5/5sandbox_escape,7/7mvp_e2e(incl.verifies_tier2_u64_range_and_make_identity_milestones),16/16integration.[real measurement]anneal-audit:4/4unit,42/42boundary_audit,31/31target_audit.[real measurement]ci/verify_starnix_e2e.py: PASS (baselineverified +zeroandmasked-identitymutations rejected inaudit).[real measurement]cargo clippy --locked(-D warnings),cargo publish --dry-run -p cargo-anneal,rustfmt --edition 2024 --config-path /dev/null --check,./ci/check_todo.sh,./ci/check_actions.sh,./ci/check_job_dependencies.sh,./ci/check_non_stable_version.sh, andsha256sum --check --strict trusted/root-manifest.sha256: PASS.Authored by an AI agent acting on joshlf's behalf.