Repository navigation
Conversation
Move the ten vendored `joshlf/skills` packages and `architectural-design` from `anneal/skills/` to repository-root `skills/` so both `zerocopy/` and `anneal/` can load them without duplicating vendored packages. Keep the three Anneal-specific policy skills (`change-review`, `source-control`, and `trust-review`) in `anneal/skills/`, expose both skill roots in `anneal/.agents/skills.json`, and update moved-skill links across `anneal/` while keeping `anneal/AGENTS.md` within its 32 KiB cumulative budget. Add `skills/vendor-lock.json` and stdlib-only `ci/check_skills.py` (wired into `ci.yml`'s `all-jobs-succeed` gate and `githooks/pre-push`) to verify vendored upstream commits, file modes (`100644`/`100755`), byte counts, and SHA-256 digests alongside `SKILL.md` frontmatter, relative Markdown links and heading anchors, `anneal/.agents/skills.json` resolution, and Anneal Pass 1 script containment inside `anneal/skills/`. Agent-authored-by: AI agent acting on joshlf's behalf
Review Receipt
Authored by an AI agent acting on joshlf's behalf. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3986 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 16 16
Lines 2469 2469
=======================================
Hits 2296 2296
Misses 173 173 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0767ee061c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - **Authorship disclosure and privacy:** Include the `Agent-authored-by:` | ||
| trailer per [`authorship-disclosure`](../authorship-disclosure/SKILL.md) | ||
| trailer per | ||
| [`authorship-disclosure`](../../../skills/authorship-disclosure/SKILL.md) | ||
| whenever an agent contributed (literal `AI agent acting on <user>'s behalf`, |
There was a problem hiding this comment.
Add the required agent-authorship trailer
The reviewed commit ends with a Markdown prose notice rather than the required Agent-authored-by: AI agent acting on joshlf's behalf Git trailer. Because this commit contains acknowledged agent-authored content, publishing or merging it in its current form loses the repository-mandated commit provenance; replace the prose notice with the prescribed trailer before publication.
AGENTS.md reference: anneal/AGENTS.md:L69-L72
Useful? React with 👍 / 👎.
| allowed_top_files={"README.md", "vendor-lock.json"}, | ||
| forbid_scripts=False, | ||
| git_modes=git_modes, |
There was a problem hiding this comment.
Apply Anneal's script ban to shared loaded skills
When a repository-root skill adds a Python/shell or executable helper, this forbid_scripts=False path accepts it—even the new test_clean_fixture_with_executable_vendored_script_passes explicitly locks in that behavior—while anneal/.agents/skills.json now loads the entire root skill directory into Anneal. This lets newly loaded skill code bypass Anneal's pre-existing Pass 1 requirement to reject scripts outside its TCB/CI areas, so either the shared tree must receive the same containment check or Anneal discovery must exclude such content.
AGENTS.md reference: anneal/AGENTS.md:L177-L183
Useful? React with 👍 / 👎.
| validate_vendor_lock( | ||
| resolved_root, skills_dir, root_files, root_empty_dirs, git_modes | ||
| ) |
There was a problem hiding this comment.
Require every vendored directory to remain locked
When a vendored package is removed from vendor-lock.json, this return value is ignored and the subsequent tree validation silently treats its directory as an ordinary repository-owned skill. For example, deleting the authorship-disclosure package entry and then modifying its SKILL.md passes check_repository as long as another package remains in the lock, defeating the provenance and immutability check this CI job is meant to provide. Compare the locked package set with an explicit repository-owned allowlist (or otherwise require every non-owned skill directory to be locked).
AGENTS.md reference: anneal/AGENTS.md:L91-L94
Useful? React with 👍 / 👎.
| display = f"{tree_rel}/{rel_posix}" | ||
| check_safe_path_string(rel_posix, display) | ||
| record_collision_check(rel_posix) |
There was a problem hiding this comment.
Reject forbidden config paths inside skill trees
When a skill contains a forbidden governing or ambient configuration such as AGENTS.override.md, .cargo/, or .agents/, this traversal only checks that the path is ASCII and collision-free, so check_repository accepts it; for example, anneal/skills/policy-review/AGENTS.override.md passes unchanged. Because both skill roots are now exposed to Anneal, enforce the repository's forbidden config-name and directory-component rules during traversal rather than allowing these files into discovered skill packages.
AGENTS.md reference: anneal/AGENTS.md:L167-L176
Useful? React with 👍 / 👎.
| INLINE_LINK_RE = re.compile( | ||
| r"!?\[(?:[^\[\]\n]|\n(?![ \t]*\n))*\]\(([^)]*)\)" | ||
| ) |
There was a problem hiding this comment.
Parse balanced parentheses in inline link destinations
When an inline Markdown destination contains balanced parentheses, this regex stops at the first ) and validates only a prefix of the real target. For example, [broken](ghost(foo).md) passes if a file named ghost(foo exists even though the actual ghost(foo).md destination is absent, while a valid parenthesized filename can be rejected. Replace the flat [^)]* capture with parsing that handles balanced/escaped parentheses so the promised relative-link check validates the rendered destination.
AGENTS.md reference: anneal/AGENTS.md:L64-L68
Useful? React with 👍 / 👎.
Human review surface
anneal/AGENTS.md,anneal/docs/review-policy-design.md, andanneal/skills/(README.md,change-review/SKILL.md,source-control/SKILL.md) update relative links to shared skills moved torepository-root
skills/and tighten non-normative wording outsideCode Review Rules(anneal/AGENTS.md:31,675->31,560bytes, keepingCode Review Rulesandanneal/.gemini/styleguide.mdbyte-identical).anneal/.agents/skills.jsonadds"../../skills"alongside"../skills"soAnneal skill discovery resolves both
anneal/skills/and repository-rootskills/.skills/(README.md,vendor-lock.json,architectural-design/, and theten vendored
joshlf/skillspackages) hoists shared general-purpose skillsfrom
anneal/skills/via pure renames, indexes shared and vendored skills inskills/README.md, and pins upstream revisions, file modes, byte counts, andSHA-256 digests in
skills/vendor-lock.json.ci/check_skills.py,ci/test_check_skills.py,githooks/pre-push, and.github/workflows/ci.yml(check-skills, required byall-jobs-succeed)enforce vendored lockfile integrity,
SKILL.mdfrontmatter, relativeMarkdown links and heading anchors,
anneal/.agents/skills.jsonresolution,and Anneal Pass 1 script containment inside
anneal/skills/.Summary
Move the ten vendored
joshlf/skillspackages andarchitectural-designfromanneal/skills/to repository-rootskills/alongsideunsafe-rust,zerocopy-development, andzerocopy-reviewso subtrees across the repositorycan share them without duplicating vendored files. Keep the three Anneal-only
policy skills (
change-review,source-control, andtrust-review) inanneal/skills/, configureanneal/.agents/skills.jsonto load both roots,and update relative links across
anneal/.Add
skills/vendor-lock.jsonand stdlib-onlyci/check_skills.py(plus unittests in
ci/test_check_skills.py) to verify vendored file modes(
100644/100755), byte sizes, and SHA-256 digests,SKILL.mdfrontmatter,relative Markdown links and
#anchorslugs, skill discovery paths, and theabsence of executable or script files under
anneal/skills/.Validation
python3 -I -B ci/check_skills.pyandpython3 -I -B -m unittest discover -s ci -p 'test_*.py' -v(all 14 testcases passing).
./ci/check_todo.sh,./ci/check_job_dependencies.sh,./ci/check_actions.sh, andzizmor --persona=pedantic --min-severity=medium .github.annealstatic and unit checks (./ci/check_todo.sh,./ci/check_job_dependencies.sh,./ci/check_actions.sh, and all 67 tests inpython3 -B -m unittest discover -s ci -p 'test_*.py' -v), plus theCode Review Rules/styleguide.mdparity andanneal/AGENTS.mdbyte-budgetchecks (
31,560 + 1,024 = 32,584 < 32,768bytes).Authored by an AI agent acting on joshlf's behalf.