Repository navigation
Conversation
Add theory/Anneal/LoopInv.lean (1711 lines, zero noncomputable defs) providing reusable, 3-axiom CFG loop-invariant, checkpoint weakest-precondition, and simulation combinators over Anneal.MirWp and Trusted.MirSemantics for Fuchsia Merkle, Starnix eBPF, and general Rust loop verification without custom axioms or bv_decide: - Checkpoint WP and execution predicates (`wpUntil`, `wpUntilOk`, `wpReach`, `execUntil`, `execUntilOk`, `execReach`) with equivalence, monotonicity, sequential composition (`wpUntil_bind`), and handover theorems (`wpUntil_to_wpOutcomeState`, `wellFormed_and_spec_of_wpUntil`). - Structured loop-invariant combinators (`wpLoop_nat`, `wpLoop_nat_le`, `wpLoop_countdown`, `wpLoop_list`, `wpLoop_list_measure`, `wpLoop_list_split`, `wpLoop_nat_or_done`, `wpLoop_state_exists`). - Relational and deterministic simulation combinators (`ReflTrans`, `wpSim_rel`, `wpSim_det_run`, `wpSim_det`) plus symbolic MIR stepping helpers and a non-vacuity `countDown` self-test. - Wire `Anneal.LoopInv` into `theory/Anneal.lean`, `trusted/cargo-anneal/src/bundle.rs`, regenerated `trusted/cargo-anneal/src/bundled_resources.rs`, and `trusted/audit/tests/boundary_audit.rs`. - Add `live_demand_driven_loopinv_three_axiom_proof` in `trusted/cargo-anneal/src/target.rs`, verifying a real `UnitTheorem` (including `BodyVerified` and symbolic return spec across all `u32` inputs for a `while n != 0` `count_down` loop) within the 3-axiom ceiling with demand-driven `Anneal.Unused` pruning. Source: https://github.com/joshlf/anneal/tree/0ac625345fa1a010e5d67d13bc15e1c55957662c Agent-authored-by: AI agent acting on joshlf's behalf
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## joshlf-anneal-p2-theory-bitvec-arith #3964 +/- ##
=====================================================================
Coverage 92.99% 92.99%
=====================================================================
Files 16 16
Lines 2469 2469
=====================================================================
Hits 2296 2296
Misses 173 173 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42862a8cc9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| subst hOut | ||
| exact ⟨hSat.1, hBeh⟩ | ||
|
|
||
| end Anneal.LoopInv |
There was a problem hiding this comment.
Correct the Human review surface line count
The commit's required Human review surface describes LoopInv.lean as 1,711 lines, but the added file ends at line 1,716. This makes the recorded review surface inaccurate; update the count or remove the brittle count before handoff.
AGENTS.md reference: anneal/AGENTS.md:L123-L129
Useful? React with 👍 / 👎.
Human review surface
Add theory/Anneal/LoopInv.lean (1711 lines, zero noncomputable defs)
providing reusable, 3-axiom CFG loop-invariant, checkpoint
weakest-precondition, and simulation combinators over Anneal.MirWp and
Trusted.MirSemantics for Fuchsia Merkle, Starnix eBPF, and general Rust
loop verification without custom axioms or bv_decide:
wpUntil,wpUntilOk,wpReach,execUntil,execUntilOk,execReach) with equivalence,monotonicity, sequential composition (
wpUntil_bind), and handovertheorems (
wpUntil_to_wpOutcomeState,wellFormed_and_spec_of_wpUntil).wpLoop_nat,wpLoop_nat_le,wpLoop_countdown,wpLoop_list,wpLoop_list_measure,wpLoop_list_split,wpLoop_nat_or_done,wpLoop_state_exists).ReflTrans,wpSim_rel,wpSim_det_run,wpSim_det) plus symbolic MIR steppinghelpers and a non-vacuity
countDownself-test.Anneal.LoopInvintotheory/Anneal.lean,trusted/cargo-anneal/src/bundle.rs, regeneratedtrusted/cargo-anneal/src/bundled_resources.rs, andtrusted/audit/tests/boundary_audit.rs.live_demand_driven_loopinv_three_axiom_proofintrusted/cargo-anneal/src/target.rs, verifying a realUnitTheorem(including
BodyVerifiedand symbolic return spec across allu32inputs for a
while n != 0count_downloop) within the 3-axiomceiling with demand-driven
Anneal.Unusedpruning.Layer 13 of 19 in the migrated Anneal verification stack under
anneal/.Public Anneal source checkpoint.
Authored by an AI agent acting on joshlf's behalf.