Repository navigation
Conversation
Replace the 5,262-line `ProductionSteps.lean` and its 265-line `generate_steps.py` script in the Starnix eBPF verification fixture with a compact symbolic MIR interpreter (`SymExec.lean`) built on top of `Anneal.MirWp`. This removes all hardcoded local, basic-block, and statement indices from the Starnix `apply_endianness` proof, shrinking the fixture proof directory by ~74% while remaining resilient to `rustc` temporary renumbering, block reordering, and `StorageLive`/`StorageDead` nops. Source: https://github.com/joshlf/anneal/tree/97b40ca0e874b5a31994c559e3af1b1a99bed1ca Agent-authored-by: AI agent acting on joshlf's behalf
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## joshlf-anneal-fuchsia-0e-verify-rustc #3959 +/- ##
======================================================================
Coverage 92.99% 92.99%
======================================================================
Files 16 16
Lines 2469 2469
======================================================================
Hits 2296 2296
Misses 173 173 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da6541e198
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Kernel-evaluated symbolic paths must first prove actual source executions of | ||
| each capture. A separate check then applies the fixed byte-reversal endpoints. |
There was a problem hiding this comment.
List every changed human-review surface
The commit's Human review surface block describes the proof replacement but does not list the changed anneal/ci/verify_starnix_e2e.py, anneal/docs/mvp.md, or the full set of trusted proof/request files. This leaves reviewers without the required complete inventory of CI, documentation, and trusted/ surfaces and blocks the commit from being marked ready until the block explicitly covers them.
AGENTS.md reference: anneal/AGENTS.md:L115-L129
Useful? React with 👍 / 👎.
| @@ -0,0 +1,954 @@ | |||
| -- Copyright 2026 The Fuchsia Authors | |||
There was a problem hiding this comment.
Add the required agent-authorship trailer
For this materially agent-authored commit, the italic Authored by... sentence is prose rather than the required Git trailer. The frozen-commit checklist requires an Agent-authored-by: trailer, so the commit message must use that trailer format before merge.
AGENTS.md reference: anneal/AGENTS.md:L70-L72
Useful? React with 👍 / 👎.
Human review surface
Replace the 5,262-line
ProductionSteps.leanand its 265-linegenerate_steps.pyscript in the Starnix eBPF verification fixturewith a compact symbolic MIR interpreter (
SymExec.lean) built on topof
Anneal.MirWp.This removes all hardcoded local, basic-block, and statement indices
from the Starnix
apply_endiannessproof, shrinking the fixture proofdirectory by ~74% while remaining resilient to
rustctemporaryrenumbering, block reordering, and
StorageLive/StorageDeadnops.Layer 8 of 19 in the migrated Anneal verification stack under
anneal/.Public Anneal source checkpoint.
Authored by an AI agent acting on joshlf's behalf.