Skip to content

[anneal] Add verify rustc mode, symlink staging, and receipt v2 - #3958

Open
joshlf wants to merge 1 commit into
joshlf-anneal-fuchsia-0d-unpinned-leanfrom
joshlf-anneal-fuchsia-0e-verify-rustc
Open

joshlf wants to merge 1 commit into
joshlf-anneal-fuchsia-0d-unpinned-leanfrom
joshlf-anneal-fuchsia-0e-verify-rustc

Conversation

@joshlf

@joshlf joshlf commented Nov 20, 2026

Copy link
Copy Markdown
Member

Human review surface

Add cargo-anneal verify rustc (for downstream build systems invoking captured rustc directly), symlink-preserving staging for CAS/Bazel layouts, and verification receipt schema v2.

Layer 7 of 19 in the migrated Anneal verification stack under anneal/.

Public Anneal source checkpoint.

Authored by an AI agent acting on joshlf's behalf.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T15:41:09.549261Z fd2dc47 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.99%. Comparing base (f52a327) to head (fd2dc47).

Additional details and impacted files
@@                           Coverage Diff                           @@
##           joshlf-anneal-fuchsia-0d-unpinned-lean    #3958   +/-   ##
=======================================================================
  Coverage                                   92.99%   92.99%           
=======================================================================
  Files                                          16       16           
  Lines                                        2469     2469           
=======================================================================
  Hits                                         2296     2296           
  Misses                                        173      173           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd2dc47f97

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

// https://github.com/leanprover/lean4/blob/5045d0056413266e57c625dcd7c365b10e377c52/src/stdlib.make.in#L157-L163
// https://github.com/leanprover/lean4/blob/5045d0056413266e57c625dcd7c365b10e377c52/src/CMakeLists.txt#L859-L872
let lean_sha = sha256_file(&self.lean, "toolchain")?;
let lean_sha = sha256_file_deref(&self.lean, "toolchain")?;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Bind the hashed Lean executable to the process you run

When --lean names a symlink, this newly accepts and hashes its current target, but the subsequent --version, --print-prefix, compilation, and audit commands execute self.lean and resolve that symlink again. If an installer or toolchain manager atomically retargets the symlink after this line, verification can run an executable whose digest was never checked against the foundation lock and still emit a successful pinned receipt. Keep an identity-bound executable handle/path for all invocations, or revalidate the resolved target at the accepting boundary.

AGENTS.md reference: anneal/AGENTS.md:L277-L280

Useful? React with 👍 / 👎.

@joshlf
joshlf added this pull request to stack #3976 November 20, 2026 17:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants