Repository navigation
Conversation
Source: https://github.com/joshlf/anneal/tree/6d022f18ecac6b833cab0c1ad8000d088739c091 Agent-authored-by: AI agent acting on joshlf's behalf
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## joshlf-anneal-fuchsia-0d-unpinned-lean #3958 +/- ##
=======================================================================
Coverage 92.99% 92.99%
=======================================================================
Files 16 16
Lines 2469 2469
=======================================================================
Hits 2296 2296
Misses 173 173 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd2dc47f97
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // https://github.com/leanprover/lean4/blob/5045d0056413266e57c625dcd7c365b10e377c52/src/stdlib.make.in#L157-L163 | ||
| // https://github.com/leanprover/lean4/blob/5045d0056413266e57c625dcd7c365b10e377c52/src/CMakeLists.txt#L859-L872 | ||
| let lean_sha = sha256_file(&self.lean, "toolchain")?; | ||
| let lean_sha = sha256_file_deref(&self.lean, "toolchain")?; |
There was a problem hiding this comment.
Bind the hashed Lean executable to the process you run
When --lean names a symlink, this newly accepts and hashes its current target, but the subsequent --version, --print-prefix, compilation, and audit commands execute self.lean and resolve that symlink again. If an installer or toolchain manager atomically retargets the symlink after this line, verification can run an executable whose digest was never checked against the foundation lock and still emit a successful pinned receipt. Keep an identity-bound executable handle/path for all invocations, or revalidate the resolved target at the accepting boundary.
AGENTS.md reference: anneal/AGENTS.md:L277-L280
Useful? React with 👍 / 👎.
Human review surface
Add
cargo-anneal verify rustc(for downstream build systems invoking capturedrustcdirectly), symlink-preserving staging for CAS/Bazel layouts, and verification receipt schema v2.Layer 7 of 19 in the migrated Anneal verification stack under
anneal/.Public Anneal source checkpoint.
Authored by an AI agent acting on joshlf's behalf.