Repository navigation
Preserve explicit variable types in UnnamedVariable when required. - #6322
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Per JLS 14.4.1, `var` cannot infer a variable's type when the initializer is an array initializer (`{...}`), has `null` or `void` type, or is a poly lambda or method reference expression (including inside parenthesized, conditional, or switch expressions). `UnnamedVariable` previously replaced the explicit type with `var` whenever an initializer was present, producing uncompilable `var _ = ...` declarations.
Check whether the initializer has a standalone inferable type before replacing the declared type with `var`, falling back to renaming only the identifier to `_` when the explicit type is required.
PiperOrigin-RevId: 1016302089
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve explicit variable types in UnnamedVariable when required.
Per JLS 14.4.1,
varcannot infer a variable's type when the initializer is an array initializer ({...}), hasnullorvoidtype, or is a poly lambda or method reference expression (including inside parenthesized, conditional, or switch expressions).UnnamedVariablepreviously replaced the explicit type withvarwhenever an initializer was present, producing uncompilablevar _ = ...declarations.Check whether the initializer has a standalone inferable type before replacing the declared type with
var, falling back to renaming only the identifier to_when the explicit type is required.