Repository navigation
fix(glass): blend the hover action rail into the row on every platform - #3672
Merged
Merged
Conversation
|
Member
|
Any way our visual regression suite could catch this in future? |
setchy
approved these changes
Nov 10, 2026
Member
|
the notification action hover color looks similar to the glass mode tooltips for sidebar buttons (ie: Settings, Filters) |
Member
Author
yeah, but one's behaviour is clearly floating on top of other things, where the other is action buttons within the row. HOWEVER, one could change them instead to three individual buttons. But maybe that can be a later experiment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
With the Glass theme on macOS, hovering a notification row shows its action buttons on a near-white box with a hairline border, separate from the row. Windows has the same problem. #3604 fixed it only on Linux.
The rail used the macOS tooltip material: a near-opaque fill with a backdrop blur. #3604 replaced that fill on Linux with the app background under the row's hover wash, which works because the Linux window is opaque. On macOS the window background is the native vibrancy material, which CSS cannot paint, so any fill there reads as a slab.
Under Glass, the rail now has no fill on any platform. The hovered row's own surface shows through, so the rail reads as part of the row. To keep row content from showing through the buttons, the rail's siblings are clipped at the rail's leading edge while the rail is shown:
.group) becomes an inline-size container, so100cqwlocates the rail inside each sibling's box.IconButtons, 1.75rem each), because disabled actions render nothing. Read rows show one button, and read Gitea, GitLab and Bitbucket rows show none.This replaces both the frosted rule and the Linux-only rule. Classic is unchanged, and Reduce Transparency and Increase Contrast still fall back to solid surfaces.
Testing
vp checkand the renderer test suite pass.