Repository navigation
fix(color-picker): guard edits when the input is disabled - #4417
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The color picker stays interactive when its attached input becomes disabled while the popover is open. A palette click or a continued drag can still change the color and emit
change.Fixes #4415.
Reproduction
Open a color picker set to red. Disable its input while the popover is open and click the blue swatch. The input changes to blue. Reproduction video
Fix
Route user edits from the built-in color picker modules through a disabled-state check before calling
setValue().Verification
In Chrome, both a palette click and a spectrum drag that was in progress at disable changed the value before the patch. Both preserved the current color and emitted no change after it. Programmatic
setValue()still worked while disabled, and the palette worked after re-enabling. The changed files passed Prettier.