Skip to content

fix(picker): ignore column edits when the input is disabled - #4416

Open
Xapollon430 wants to merge 1 commit into
framework7io:masterfrom
Xapollon430:codex/guard-disabled-picker-column
Open

Xapollon430 wants to merge 1 commit into
framework7io:masterfrom
Xapollon430:codex/guard-disabled-picker-column

Conversation

@Xapollon430

Copy link
Copy Markdown

Problem

An open picker continues to write to its input after the input becomes disabled. Clicking a column item or scrolling the column can still change the value.

Fixes #4414.

Reproduction

Open a picker set to Apple. Disable its input while the popover is open and click Banana. The disabled input changes to Banana and emits change. Reproduction video

Fix

Check the attached input before handling a column click or scroll. Both paths can commit a value independently.

Verification

Native Chrome clicks and wheel scrolling changed the disabled value before the patch. Both kept Apple and emitted no change after the patch. Programmatic setValue() still worked while disabled, and clicking Banana after re-enabling selected it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Picker still changes value when its input becomes disabled while open

1 participant