Repository navigation
fix(picker): ignore column edits when the input is disabled - #4416
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An open picker continues to write to its input after the input becomes disabled. Clicking a column item or scrolling the column can still change the value.
Fixes #4414.
Reproduction
Open a picker set to Apple. Disable its input while the popover is open and click Banana. The disabled input changes to Banana and emits
change. Reproduction videoFix
Check the attached input before handling a column click or scroll. Both paths can commit a value independently.
Verification
Native Chrome clicks and wheel scrolling changed the disabled value before the patch. Both kept Apple and emitted no change after the patch. Programmatic
setValue()still worked while disabled, and clicking Banana after re-enabling selected it.