Repository navigation
Conversation
|
Documentation preview for this pull request is available at: |
| @@ -0,0 +1,92 @@ | |||
| # ******************************************************************************* | |||
There was a problem hiding this comment.
What exactly are we testing here?
The links inside the full/partially verifies?
There was a problem hiding this comment.
Checks for three requirements: tool_req__docs_test_metadata_mandatory_1, tool_req__docs_test_metadata_mandatory_2, and tool_req__docs_test_metadata_link_levels.
|
Should these be tested & asserted here? I guess in a way we need it to have better coverage, but those tests & checks I would see actually in the plugin so in There we also have commented out a bunch of |
Cannot really write tests yet because of the "info-only". Waiting for a later release to make these mandatory. The whole point of this PR is to have checks not in score_tools. Checking there does not catch testcase items introduced from other sources. |
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| """Validation rules for testcase needs, independent of their source.""" |
There was a problem hiding this comment.
can you explain that/why metadata.yml constraints are not applied here
There was a problem hiding this comment.
Because they are external needs which are excluded from the graph & local checks via our filter.
But I think it makes more sense to include them in that filter instead of making a whole new file for them specifically.
|
@a-zw Is this still up to date and relevant, or should I not review this? |
📌 Description
Check all
testcaseneed items - even the external ones.🚨 Impact Analysis
✅ Checklist