Repository navigation
Conversation
Change the logic_arc_int included_by feat link from optional to mandatory, ending the migration period. The old feat includes logic_arc_int direction remains optional for backward compatibility. Closes eclipse-score#971
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Some questions.
a-zw
marked this pull request as ready for review
November 10, 2026 15:00
a-zw
requested review from
AlexanderLanin,
dcalavrezo-qorix and
nradakovic
as code owners
November 10, 2026 15:00
MaximilianSoerenPollak
previously approved these changes
Nov 10, 2026
Signed-off-by: Andreas Zwinkau <95761648+a-zw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Change the logic_arc_int included_by feat link from optional to mandatory, ending the migration period. The old feat includes logic_arc_int direction remains optional for backward compatibility.
Closes #971
🚨 Impact Analysis
✅ Checklist