Skip to content

Linker doesn't use correct TypeDefinition to determine if a method is needed as an override of an interface method #98255

Closed

Description

@jtschuster

See #97487 (comment) for more details.

There could be a method on a base type that provides an implementation for an interface implementation. Using that type as the "Implementing type" is incorrect, but will lead to correct results because the method will be kept if the "Implementing type" is marked as instantiated, and because all base types are marked as instantiated if the derived type is.

Activity

  1. self-assigned this
    on Feb 10, 2024
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Feb 10, 2024
  3. changed the title [-]Linker doesn't use correct type to determine if a method is needed as an override of an interface method[/-] [+]Linker doesn't use correct TypeDefinition to determine if a method is needed as an override of an interface method[/+] on Feb 10, 2024
  4. removed
    untriagedNew issue has not been triaged by the area owner
    on Feb 10, 2024
  5. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Feb 11, 2024
  6. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Feb 29, 2024
  7. locked and limited conversation to collaborators on Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-Tools-ILLink.NET linker development as well as trimming analyzers

Type

No type

Projects

  • Status
    No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions