Skip to content

compiler: Misc tweaks to fully support FP16 storage/compute across all backends - #3109

Open
FabioLuporini wants to merge 11 commits into
mainfrom
fix/fp16-wdr-storage
Open

FabioLuporini wants to merge 11 commits into
mainfrom
fix/fp16-wdr-storage

Conversation

@FabioLuporini

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.47887% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.00%. Comparing base (448e7da) to head (94a74ce).

Files with missing lines Patch % Lines
devito/ir/iet/visitors.py 50.00% 1 Missing and 1 partial ⚠️
devito/mpi/routines.py 0.00% 1 Missing ⚠️
devito/passes/iet/definitions.py 92.30% 1 Missing ⚠️
devito/symbolics/extended_sympy.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3109      +/-   ##
==========================================
- Coverage   84.44%   84.00%   -0.44%     
==========================================
  Files         260      260              
  Lines       58782    58897     +115     
  Branches     4989     4995       +6     
==========================================
- Hits        49640    49478     -162     
- Misses       8314     8567     +253     
- Partials      828      852      +24     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX ?
pytest-gpu-gcc- 79.21% <96.47%> (+0.04%) ⬆️
pytest-gpu-icx- 42.62% <35.91%> (-36.49%) ⬇️
pytest-gpu-nvc-nvidiaX 69.20% <53.76%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Codex added 5 commits November 11, 2026 15:03
Use arithm-mode throughout symbolic lowering and include generated source and compiler ABI in every Operator signature. Preserve scalar component and cast-pointer result types for ordinary packed accesses.

Validate focused CPU typing, JIT identity and serialization checks, plus the dependent PRO GPU arithmetic checks.
Store the picklable pointee type and indirection in standard reconstruction
metadata, deriving the full ctype on demand. Remove the custom ctypes pointer
reducer and cover pointer depth, equality, scope and serialization.
Resolve MPI neighbors from the execution Grid so reconstructed internal Arrays communicate between decoupler workers. Also wrap the overlong symbolic-test imports.
Codex added 2 commits November 11, 2026 17:41
Return a conservative result for C-only types such as size_t instead of passing NumPy's TypeError through FP16 code generation. Cover numeric ctypes and opaque dtypes in scalar and mixed argument queries.

Validation: 9 targeted OSS symbolic tests, 12 CUDA regression and adjacent tests, isort, Flake8, and Ruff.
Select the RHS precision before creating an exact-precision printer and forward normalized Operator options to dtype-specific lowering passes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants