Skip to content

Add support for Alpine to git feature - #1008

Merged
Samruddhi Khandale (samruddhikhandale) merged 41 commits into
devcontainers:mainfrom
jonbackhaus:git-alpine
Jun 27, 2024
Merged

Samruddhi Khandale (samruddhikhandale) merged 41 commits into
devcontainers:mainfrom
jonbackhaus:git-alpine

Conversation

@jonbackhaus

@jonbackhaus Jonathan Backhaus (jonbackhaus) commented Jun 19, 2024 •

Copy link
Copy Markdown
Contributor

This PR introduces support of Alpine Linux to the git dev container feature.

@jonbackhaus
Jonathan Backhaus (jonbackhaus) requested a review from a team as a code owner June 19, 2024 02:11
@jonbackhaus

Copy link
Copy Markdown
Contributor Author

Jonathan Backhaus (@jonbackhaus) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time in contributing the support for Alpine. Left some comments!

Comment thread src/git/install.sh Resolved
Comment thread src/git/install.sh Resolved
Comment thread src/git/NOTES.md Resolved

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have failing tests and builds, can you help fix them? Thanks!

…talled); refactor test script names to remove major version suffix (since it isn't specified in the associated image tag)
Comment thread src/git/install.sh Resolved
Comment thread src/git/install.sh Resolved
Comment thread test/git/install_git_from_src_alpine.sh Resolved
Comment thread src/git/install.sh Resolved
Comment thread src/git/install.sh Resolved
Comment thread src/git/install.sh Resolved
using `jq` avoids the need for PCRE `grep` expression (not supported in Alpine)
not present in local Git feature in `base-alpine` image `install.sh` script
…se-alpine` image

no longer needed, based on initial testing
…al Git feature in `base-alpine` image

`jq` package no longer needed
…e system package is not built with PCRE support)
@jonbackhaus Jonathan Backhaus (jonbackhaus) changed the title Add support for Alpine apk to Git feature Add support for Alpine to git feature Jun 27, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you so much 🎉

@samruddhikhandale
Samruddhi Khandale (samruddhikhandale) merged commit 694906e into devcontainers:main Jun 27, 2024
@h3xcat

Copy link
Copy Markdown
Contributor

Looks like tests are failing for alpine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants