Repository navigation
Add support for Alpine to git feature - #1008
Merged
Samruddhi Khandale (samruddhikhandale) merged 41 commits intoJun 27, 2024
Merged
Samruddhi Khandale (samruddhikhandale) merged 41 commits into
Samruddhi Khandale (samruddhikhandale) merged 41 commits into
Conversation
the alpine version of `grep` doesn't support PCRE
note: this won't install from source (due to build issues with musl) but will install using the `apk` package manager
Contributor
Author
@microsoft-github-policy-service agree |
Samruddhi Khandale (samruddhikhandale)
requested changes
Jun 19, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thank you for taking the time in contributing the support for Alpine. Left some comments!
note: feature does not currently implement building from source on Alpine
Samruddhi Khandale (samruddhikhandale)
requested changes
Jun 21, 2024
still need to tweak the package dependencies and make config
no longer required with "NO_GETTEXT=YesPlease" make config
no longer required with "NO_GETTEXT=YesPlease" make config (?)
Jonathan Backhaus (jonbackhaus)
requested a review
from Samruddhi Khandale (samruddhikhandale)
June 24, 2024 11:21
Samruddhi Khandale (samruddhikhandale)
requested changes
Jun 24, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Looks like we have failing tests and builds, can you help fix them? Thanks!
…talled); refactor test script names to remove major version suffix (since it isn't specified in the associated image tag)
Samruddhi Khandale (samruddhikhandale)
requested changes
Jun 25, 2024
using `jq` avoids the need for PCRE `grep` expression (not supported in Alpine)
…rom `install_git_from_src.sh` script
not present in local Git feature in `base-alpine` image `install.sh` script
…it feature in `base-alpine` image
…se-alpine` image no longer needed, based on initial testing
…al Git feature in `base-alpine` image `jq` package no longer needed
…e system package is not built with PCRE support)
apk to Git featuregit feature
Samruddhi Khandale (samruddhikhandale)
approved these changes
Jun 27, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Wonderful, thank you so much 🎉
Contributor
|
Looks like tests are failing for alpine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support of Alpine Linux to the
gitdev container feature.