Repository navigation
fix(expect): handle ArrayBuffers, DataViews, error constructors, and boxed primitives in toStrictEqual - #7393
Open
helmipradita wants to merge 1 commit into
Conversation
…boxed primitives in toStrictEqual Refs denoland#7387
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7393 +/- ##
==========================================
- Coverage 95.04% 95.02% -0.02%
==========================================
Files 619 618 -1
Lines 52012 51799 -213
Branches 9450 9424 -26
==========================================
- Hits 49434 49224 -210
+ Misses 2031 2022 -9
- Partials 547 553 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #7387
Description
In
@std/expectequality matching (particularly understrictCheck: truefortoStrictEqual):a instanceof Error && b instanceof Errorchecked onlya.message === b.messagebefore strict constructor check, causingnew Error("m")andnew TypeError("m")to evaluate as equal.constructorsEqualtreated!a.constructor && b.constructor === Objectas equal; withstrictCheck: trueit now requires exact constructor equality (a.constructor === b.constructor), correctly rejectingObject.create(null)against{}.Number,Boolean,Symbol, andBigIntwrapper objects now compare their underlying values viasameValueZero.Setin_equal.tsand_utils.ts(iterableEquality) prevents duplicate object entries inafrom repeatedly matching the same entry inb.