Repository navigation
fix(assert): handle boxed primitives and duplicate keys in keyed collections in equal - #7392
Open
helmipradita wants to merge 1 commit into
Open
helmipradita wants to merge 1 commit into
helmipradita wants to merge 1 commit into
Conversation
…ections in equal Refs denoland#7387
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7392 +/- ##
==========================================
- Coverage 95.04% 95.03% -0.02%
==========================================
Files 619 618 -1
Lines 52012 51771 -241
Branches 9450 9411 -39
==========================================
- Hits 49434 49199 -235
+ Misses 2031 2022 -9
- Partials 547 550 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #7387
Description
In
@std/assertequal():new Number(1),new Boolean(true),Object(1n),Object(sym)) have no own enumerable keys and were treated as empty objects matching each other regardless of their underlying primitive values. This adds checks comparing their.valueOf()usingsameValueZero.SetandMapcollections with object elements/keys, the non-primitive loop simply decremented a counter whenever an entry inamatched any entry inb, without tracking whether that entry inbwas already matched. As a result, duplicate entries could match the same target entry multiple times (e.g.Set([{a: 1}, {a: 1}])vsSet([{a: 1}, {a: 2}])). This tracks unmatched entries ofbusing aSetand deletes entries upon matching.