Repository navigation
docs(bindings/s3): document TLS metadata aliases - #5492
Open
VictorMoni wants to merge 1 commit into
Open
VictorMoni wants to merge 1 commit into
VictorMoni wants to merge 1 commit into
Conversation
Signed-off-by: victormoni <victor-moni@hotmail.com>
4 tasks done
Contributor
|
Claude review · not a review sign-off. No findings. The new names and the precedence rule (the SSL name wins when both are set, even when it is Reviewed at 048db46. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents the AWS S3 binding's
disableTLSandinsecureTLSmetadata aliases, updates the example and Minio instructions, and explains that the existing SSL names remain supported and take precedence when both names are provided.Companion implementation: dapr/components-contrib#4769
Issue: dapr/components-contrib#2983
Targets v1.20 because these aliases are introduced by the pending implementation. Please merge alongside that change.
Validation:
git diff --checkpassed; reviewed the YAML example and Markdown table. The full Hugo site build was not run. The implementation's S3 unit suite,go vet, and component metadata bundle validation passed.Prepared with assistance from OpenAI Codex.