Skip to content

docs(bindings/s3): document TLS metadata aliases - #5492

Open
VictorMoni wants to merge 1 commit into
dapr:v1.20from
VictorMoni:docs/s3-tls-aliases
Open

VictorMoni wants to merge 1 commit into
dapr:v1.20from
VictorMoni:docs/s3-tls-aliases

Conversation

@VictorMoni

Copy link
Copy Markdown

Description

Documents the AWS S3 binding's disableTLS and insecureTLS metadata aliases, updates the example and Minio instructions, and explains that the existing SSL names remain supported and take precedence when both names are provided.

Companion implementation: dapr/components-contrib#4769
Issue: dapr/components-contrib#2983

Targets v1.20 because these aliases are introduced by the pending implementation. Please merge alongside that change.

Validation: git diff --check passed; reviewed the YAML example and Markdown table. The full Hugo site build was not run. The implementation's S3 unit suite, go vet, and component metadata bundle validation passed.

Prepared with assistance from OpenAI Codex.

@VictorMoni
VictorMoni requested review from a team as code owners November 15, 2026 16:23
Signed-off-by: victormoni <victor-moni@hotmail.com>
@CasperGN

Copy link
Copy Markdown
Contributor

Claude review · not a review sign-off.

No findings. The new names and the precedence rule (the SSL name wins when both are set, even when it is "false") match the metadata tests in the companion components-contrib change. Not approving because that change is still open and the docs workflows on this head are waiting for maintainer approval; as the description says, this should merge together with it.

Reviewed at 048db46.
Disagree, or want to talk it through? Reply /human and Casper will pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants