Skip to content

fix transStart() connection init - #346

Merged
lonnieezell merged 1 commit into
codeigniter4:developfrom
takekoshinet:fix/db-transaction-start-as-first-query
Jan 2, 2017
Merged

lonnieezell merged 1 commit into
codeigniter4:developfrom
takekoshinet:fix/db-transaction-start-as-first-query

Conversation

@takekoshinet

Copy link
Copy Markdown
Contributor

When $db->transStart() is called before any query, an error occurs because connID is false.

An uncaught Exception was encountered

Type:        Error
Message:     Call to a member function autocommit() on boolean
Filename:    /path/to/project/system/Database/MySQLi/Connection.php
Line Number: 479

Lazy initialize calling is lacked on trans*()

@lonnieezell

Copy link
Copy Markdown
Member

Good catch!

@lonnieezell
lonnieezell merged commit 1d5ab0b into codeigniter4:develop Jan 2, 2017
@takekoshinet
takekoshinet deleted the fix/db-transaction-start-as-first-query branch January 17, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants