Repository navigation
Conversation
r6 adds upstream's fix for a force-close right after a splice locks (rust-lightning #4577, backported): a peer's announcement_signatures for the pre-splice channel are ignored instead of closing the channel, and none are sent for it on reestablish. ldk-node's channel_full_cycle_0conf failed on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107
What changes
Cargo.toml: +11/-11The ten
lightning*entries move from the r5 rev toblocknil-0.2.8-r6(3323bbdf). r6 addsupstream's fix for a force-close right after a splice locks (lightningdevkit/rust-lightning#4577, backported):
a peer's
announcement_signaturesfor the pre-splice channel are ignored instead of closing thechannel, and none are sent for it on reestablish.
How it was tested
On
blocknil-0.7.1-r5(73a3c97): the library tests — 37 passed;integration_tests_rust— 34/34 (its five-consecutive-run record was taken on r45554a0a, on the Mac); the doc tests — 2; the VSS suites — 2 + 3; the CLN suite — 1; the LND suite — 1.On the rust-lightning r5 pin (before this commit)
channel_full_cycle_0conffails; on r6 it passes.Risks
All ten crates must share one rev, and the rev has to exist on the published branch. Nothing else in
the tree depends on the r5 behaviour.
Upstream
Not applicable. Label: build.
Landed on
blocknil-0.7.1-r5as ca9c976. This PR records the patch; it is not merged here.