Skip to content

Build against our rust-lightning fork blocknil-0.2.8-r6 - #108

Closed
jbesraa wants to merge 1 commit into
patch/ldk-55-basefrom
patch/ldk-55
Closed

jbesraa wants to merge 1 commit into
patch/ldk-55-basefrom
patch/ldk-55

Conversation

@jbesraa

@jbesraa jbesraa commented Nov 14, 2026

Copy link
Copy Markdown

Fixes #107

What changes

  • Cargo.toml: +11/-11

The ten lightning* entries move from the r5 rev to blocknil-0.2.8-r6 (3323bbdf). r6 adds
upstream's fix for a force-close right after a splice locks (lightningdevkit/rust-lightning#4577, backported):
a peer's announcement_signatures for the pre-splice channel are ignored instead of closing the
channel, and none are sent for it on reestablish.

How it was tested

On blocknil-0.7.1-r5 (73a3c97): the library tests — 37 passed; integration_tests_rust — 34/34 (its five-consecutive-run record was taken on r4 5554a0a, on the Mac); the doc tests — 2; the VSS suites — 2 + 3; the CLN suite — 1; the LND suite — 1.

On the rust-lightning r5 pin (before this commit) channel_full_cycle_0conf fails; on r6 it passes.

Risks

All ten crates must share one rev, and the rev has to exist on the published branch. Nothing else in
the tree depends on the r5 behaviour.

Upstream

Not applicable. Label: build.

Landed on blocknil-0.7.1-r5 as ca9c976. This PR records the patch; it is not merged here.

r6 adds upstream's fix for a force-close right after a splice locks (rust-lightning #4577,
backported): a peer's announcement_signatures for the pre-splice channel are ignored instead of
closing the channel, and none are sent for it on reestablish. ldk-node's channel_full_cycle_0conf
failed on it.
@jbesraa jbesraa added the build Build and dependency changes label Nov 14, 2026
@jbesraa jbesraa closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build and dependency changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant