Skip to content

Style changes - #44

Merged
jamesob merged 1 commit into
bitcoinops:masterfrom
jnewbery:style_changes
Jul 25, 2018
Merged

jamesob merged 1 commit into
bitcoinops:masterfrom
jnewbery:style_changes

Conversation

@jnewbery

Copy link
Copy Markdown
Contributor
  • Centers titles and date
  • adds date to newsletter posts
  • adds space between the horizontal bar and text

blog post before:

image

blog post after:

image

newsletter before:

image

newsletter after:

image

@jnewbery

Copy link
Copy Markdown
Contributor Author

@jamesob has already visually reviewed these changes

@harding

harding commented Jul 25, 2018

Copy link
Copy Markdown
Collaborator

utACK.

This doesn't add the bar and it does make it look better, so technically this paragraph is out of scope for this PR, but I'll note that I don't understand why the bar is there and think the page would look better without it (but it's not a big deal for me).

- Centers titles and date
- adds space between the horizontal bar and text
@jnewbery

Copy link
Copy Markdown
Contributor Author

I don't understand why the bar is there and think the page would look better without it

Agree - I've removed the bar (I think that might have been added by a copy-paste error from the front-matter 😳 )

I also noticed that this branch centered the h1s in the about, newsletter and workshop pages, which I don't think we want. I've updated the commit to add a new post.css file.

@jamesob
jamesob merged commit feeac17 into bitcoinops:master Jul 25, 2018
@jnewbery jnewbery mentioned this pull request Jul 25, 2018
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Apr 29, 2019
harding pushed a commit to harding/bitcoinops.github.io that referenced this pull request Apr 29, 2019
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Apr 29, 2019
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Apr 29, 2019
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Apr 30, 2019
harding pushed a commit to harding/bitcoinops.github.io that referenced this pull request Apr 30, 2019
jnewbery added a commit that referenced this pull request Apr 30, 2019
@jnewbery
jnewbery deleted the style_changes branch October 8, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants