Repository navigation
Conversation
bitschmidty
reviewed
Nov 9, 2026
bitschmidty
left a comment
Contributor
There was a problem hiding this comment.
I pushed some suggestions, let me know @bittomhan
murchandamus
reviewed
Nov 9, 2026
| CSV use minimal overhead, but adding each new special introspection | ||
| opcode requires a consensus change and it may not be possible to | ||
| disable their use (even if they become unpopular) without risking | ||
| someone losing money. |
Collaborator
There was a problem hiding this comment.
Looking at the whole article, I feel there is still some work left to make it fit in the context of the whole article: the next section is titled “Relationship to OP_CAT”, but all of the edited segment relates to the relationship of OP_CSFS and OP_CAT.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2267.
The
OP_CSFStopic page listed Transaction introspection as a feature ofOP_CSFS, and later said it "provides full introspection of the signing transaction".OP_CSFSalone does not do that: it verifies a signature over the message sitting on the stack as a single element, and gives a script no way to examine individual fields. The introspection use case assumes an opcode that can rebuild the signed message from fields the script has already checked —OP_CAT, which the page already describes under Relationship to OP_CAT.This PR makes that dependency explicit in three places rather than leaving it implied:
OP_CAT(with a[topic op_cat]link and a pointer to the existing section);OP_CSFSandOP_CAThad been available in 2015 and 2016";OP_CSFSalone.While editing the same sentence, I also dropped a stray word in "using without any consensus changes".
Notes for the reviewer
**Transaction introspection:**, soid="transaction-introspection"is unchanged and existing deep links still work. Only the prose changed.OP_CSFS/OP_CATpages having once been one page. If you already have wording in mind, or would rather handle it yourself, say so and I will close this.Verification
bundle exec jekyll buildpasses (exit 0).id="transaction-introspection"is still present exactly once, and the new[topic op_cat]reference renders as a link to/en/topics/op_cat/with no literal reference text left over.mdl -r MD009, and_contrib/find-bad-indentationall pass for the changed file.