Skip to content

Topics: qualify CSFS introspection as depending on OP_CAT - #2942

Open
bittomhan wants to merge 2 commits into
bitcoinops:masterfrom
bittomhan:topic/csfs-introspection
Open

bittomhan wants to merge 2 commits into
bitcoinops:masterfrom
bittomhan:topic/csfs-introspection

Conversation

@bittomhan

Copy link
Copy Markdown
Contributor

Summary

Fixes #2267.

The OP_CSFS topic page listed Transaction introspection as a feature of OP_CSFS, and later said it "provides full introspection of the signing transaction". OP_CSFS alone does not do that: it verifies a signature over the message sitting on the stack as a single element, and gives a script no way to examine individual fields. The introspection use case assumes an opcode that can rebuild the signed message from fields the script has already checked — OP_CAT, which the page already describes under Relationship to OP_CAT.

This PR makes that dependency explicit in three places rather than leaving it implied:

  • the bullet now says the spender has to supply the field separately and the script has to reassemble the message, so the use case assumes OP_CAT (with a [topic op_cat] link and a pointer to the existing section);
  • the CLTV/CSV counterfactual is qualified to "if OP_CSFS and OP_CAT had been available in 2015 and 2016";
  • "provides full introspection" is attributed to the combination rather than to OP_CSFS alone.

While editing the same sentence, I also dropped a stray word in "using without any consensus changes".

Notes for the reviewer

  • No anchor changes. The bullet keeps its existing text **Transaction introspection:**, so id="transaction-introspection" is unchanged and existing deep links still work. Only the prose changed.
  • @harding you are assigned to this issue and suggested the paragraph may be an artifact of the OP_CSFS / OP_CAT pages having once been one page. If you already have wording in mind, or would rather handle it yourself, say so and I will close this.

Verification

  • bundle exec jekyll build passes (exit 0).
  • In the built page, id="transaction-introspection" is still present exactly once, and the new [topic op_cat] reference renders as a link to /en/topics/op_cat/ with no literal reference text left over.
  • Topic schema validator, mdl -r MD009, and _contrib/find-bad-indentation all pass for the changed file.
  • 1 file, +19/−11, wording only.

@bitschmidty bitschmidty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some suggestions, let me know @bittomhan

CSV use minimal overhead, but adding each new special introspection
opcode requires a consensus change and it may not be possible to
disable their use (even if they become unpopular) without risking
someone losing money.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the whole article, I feel there is still some work left to make it fit in the context of the whole article: the next section is titled “Relationship to OP_CAT”, but all of the edited segment relates to the relationship of OP_CSFS and OP_CAT.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

topics: OP_CHECKSIGFROMSTACK: CSFS does not enable introspection

3 participants