Skip to content

Founding sponsors on one row - #21

Merged
jnewbery merged 2 commits into
masterfrom
one-row-sponsors
Jul 13, 2018
Merged

jnewbery merged 2 commits into
masterfrom
one-row-sponsors

Conversation

@jamesob

@jamesob jamesob commented Jul 12, 2018

Copy link
Copy Markdown
Contributor

selection_066

@jamesob

jamesob commented Jul 12, 2018

Copy link
Copy Markdown
Contributor Author

Ah oops - this broke /about. Fixing.

@jamesob

jamesob commented Jul 12, 2018 •

Copy link
Copy Markdown
Contributor Author

Fixed /about:

selection_068

Also

  • trimmed @harding's title down to "Technical writer" (can revert if preferred)
  • shortened my quote a bit.

@harding

harding commented Jul 12, 2018

Copy link
Copy Markdown
Collaborator

Doesn't render well in Firefox and will probably break in Chrom(e|inium) if you play around with the responsive preview mode at various widths. At a super-quick look at the diff, I'd guess the problem is the removal of the nth-child clear rule, without which the layout engine tries to fit the content wherever it can rather than ensuring that all the previous floating content has been filled before filling new content. I can look into it more tomorrow if you'd like.

(As for changing my title, that's fine. I have no strong preferences. If we ever meet in person sometime, you should ask me about my amusing story related to job titles.)

2018-07-12-15_59_24_757298143

@jamesob

jamesob commented Jul 12, 2018

Copy link
Copy Markdown
Contributor Author

Hm, odd - the screenshot was from Chromium. I'll be sure to test in Firefox, and may special-case ul.associates with an n'th clear.

If we ever meet in person

@jnewbery, @marcinja, and I would love to drive south sometime and grab a beer! Serious offer!

@jamesob

jamesob commented Jul 12, 2018

Copy link
Copy Markdown
Contributor Author

Strange; works for me in Firefox:

about bitcoin optech - mozilla firefox_069

@harding

harding commented Jul 13, 2018

Copy link
Copy Markdown
Collaborator

Tested ACK 0f0c674

I rechecked after some sleep and discovered that somehow I hadn't checked out the latest branch head. Pulling the latest, it works for me. Forcing a min-height on the content seems slightly dangerous, as it'll be easy to make a change that later results in breaking something, e.g.:

2018-07-13-06_29_38_924023820

But fixing that problem correctly probably means redoing this with CSS flexbox or something. So this solution seems satisfactory for now since it does improve the ascetics IMO.

@jnewbery, @marcinja, and I would love to drive south sometime and grab a beer! Serious offer!

You guys are nuts, then. :-) It's a four hour round trip from NYC to here even with your own car. The sane thing to do is to wait until my list of things to do---and people to meet---in NYC grows to a length where I get unlazy enough to actually hop the bus to go there.

@jnewbery

Copy link
Copy Markdown
Contributor

Tested ACK 0f0c674. New layout is 😗 👌

@jnewbery
jnewbery merged commit 66f4d5c into master Jul 13, 2018
harding referenced this pull request in harding/bitcoinops.github.io Nov 10, 2018
jnewbery pushed a commit to jnewbery/bitcoinops.github.io that referenced this pull request Nov 11, 2018
harding referenced this pull request in harding/bitcoinops.github.io Nov 12, 2018
jnewbery referenced this pull request in harding/bitcoinops.github.io Nov 13, 2018
jnewbery added a commit that referenced this pull request Nov 13, 2018
@jnewbery
jnewbery deleted the one-row-sponsors branch February 8, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants