Skip to content

Add email subscription form to / and /newsletters - #19

Merged
jnewbery merged 2 commits into
masterfrom
subscribe-form
Jul 15, 2018
Merged

jnewbery merged 2 commits into
masterfrom
subscribe-form

Conversation

@jamesob

@jamesob jamesob commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Note that this is based on #18 which should be tested and merged first.

selection_062

Comment thread newsletters.md Outdated
{%- endfor -%}
</ul>

{% include newsletter-signup.html %}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest moving this to the top of the page, probably right after the end of the YAML header (line 11) so it displays below the Newsletters page heading but above the list. The reason is that the list of newsletters is going to get longer over time, so this box will move further down the page few people ever see it.

You may also wish to add it to each newsletter (in the same position right below the end of the YAML header), as those pages may receive a lot of incoming link traffic. There are a few ways to do this, such as creating a layout special to newsletters, putting it in the page layout triggered by a news_signup: true option in the YAML header, or just putting the {% include %} in each newsletter---the later is the easiest for now, so I'd suggest that.

Otherwise this LGTM. I tested and it took me to the mailchimp page and from there back to the live site, but they didn't ask me for double opt-in, so maybe it's in some sort of test mode?

@jnewbery

Copy link
Copy Markdown
Contributor

requires rebase on rebased #18.

@jnewbery

Copy link
Copy Markdown
Contributor

rebase plz 🙏

@jamesob

jamesob commented Jul 12, 2018

Copy link
Copy Markdown
Contributor Author

Rebased and addressed @harding's good feedback. The form is now above the list of newsletters, and I've added a newsletter layout that contains a signup form at the bottom of the page.

@harding

harding commented Jul 12, 2018

Copy link
Copy Markdown
Collaborator

Tested ACK 41dead2, a rather unfortunate commit id, with the caveat that a test of signup doesn't do double opt-in, so I think the list is in test mode or Mailchimp doesn't follow best practices.

@jnewbery

Copy link
Copy Markdown
Contributor

Tested ACK 41dead2, a rather unfortunate commit id

I think Satoshi is trying to communicate with us.

@jnewbery

Copy link
Copy Markdown
Contributor

@jamesob is out of office today, so I've gone ahead and pushed a new branch. Changes:

  • squashed commits down to two
  • changed the CSS slightly so the subscribe area doesn't have a white box surrounding it.
  • changed the mailchimp list that the subscribe form adds the subscriber to. Dave - this should fix your comment about double opt-in. Feel free to retest.
  • changed the wording from Get newsletter to Subscribe to our newsletter

@harding

harding commented Jul 14, 2018

Copy link
Copy Markdown
Collaborator

Fully tested ACK 258bdbf Thanks!

@jnewbery
jnewbery merged commit b06d8d5 into master Jul 15, 2018
@jnewbery

Copy link
Copy Markdown
Contributor

Thanks @jamesob for code and @harding for review 🌠

harding referenced this pull request in harding/bitcoinops.github.io Oct 29, 2018
harding referenced this pull request in harding/bitcoinops.github.io Oct 30, 2018
harding referenced this pull request in harding/bitcoinops.github.io Oct 30, 2018
jnewbery referenced this pull request in harding/bitcoinops.github.io Oct 30, 2018
jnewbery added a commit that referenced this pull request Oct 30, 2018
@jnewbery
jnewbery deleted the subscribe-form branch February 8, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants