Repository navigation
Conversation
simethan
marked this pull request as ready for review
November 13, 2026 16:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #10852
Description of changes:
parse_timestamprendered epoch timestamps withdateutil'stzlocal(), which derives its standard/DST offsets from Jan 1 / Jul 1 of the current year. For zones whose rules changed mid-year (America/Vancouver in 2026, tzdata 2026b: standard offset moved from -08:00 to -07:00), it kept reporting the stale -08:00 offset. Epoch values now go through the stdlib (fromtimestamp(..., utc).astimezone()), which applies the per-instant offset from libc; other tzinfo options (e.g.tzwinlocal) are unchanged.Description of tests:
Added
test_parse_epoch_uses_system_offset_when_tzlocal_is_stale(fails before, passes after);tests/unit/botocore/test_utils.py: 317 passed, 11 failed — the 11 failures are pre-existingTestSSOTokenFetcherfailures, identical on pristine code.ruff checkclean.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Generated by AI tools, and reviewed by Ethan Sim.