Repository navigation
Conversation
| return hasher.finalize() | ||
| } | ||
|
|
||
| public static func uncompress(source: URL, destination: URL) throws { |
There was a problem hiding this comment.
I removed this in #1372 because it's insecure and should not be used. See ArchiveReader.extractContents() in containerization in this commit: apple/containerization@3e93416
|
Can you provide a simple |
51afad8 to
a1a47f2
Compare
Please see PR description |
a1a47f2 to
88f75af
Compare
|
@jglogan are you still considering this? |
|
One hunk in this PR is worth a lot on its own. In On a synthetic 12,204-file context with The archive's entry names come out identical, including when the process's working directory is the context itself, which is where the old call adds trailing slashes to directories. If the full change is hard to review, I'm happy to open just that line as a small PR. |
Type of Change
Motivation and Context
While building out a Docker Compose-style plugin and validating it against our own real development stack, we ran into two classes of problems in the build-context path:
This PR fixes build-context archiving in
containerso symlinks are preserved correctly, digest calculation reflects symlink target changes, and fssync archives the exact selected file set in the already-computed order.Before this change, build-context archiving could mis-handle symlinks, archive a broader tree walk than necessary, and produce a digest that did not change when symlink targets changed.
Part of the fix was also more generally related to the Containerization framework. This PR intentionally stays independently mergeable against the current released
containerizationdependency, so it keeps the local archiver implementation needed for these fixes today. The Containerization PR is: apple/containerization#652Validation
This is an example of the problem the PR actually fixes.
Build context:
Build command:
Observed results:
rel-patch-retest:latestTesting