Repository navigation
drivers/serial/uart_pci_16550: Share the device interrupt between its ports - #22024
Open
raiden00pl wants to merge 2 commits into
Open
raiden00pl wants to merge 2 commits into
raiden00pl wants to merge 2 commits into
Conversation
Return nonzero if the UART had an interrupt pending. The handler of an interrupt shared by several UARTs needs this to know when none of them asserts the interrupt any more. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: raiden00pl <raiden00@railab.me>
… ports. All ports of one PCI function share its interrupt, but every port attached and enabled it on its own: opening a second port replaced the handler of the first port, and closing a port disabled the interrupt of the others. Attach the interrupt of a device once when it is probed and service all its ports in the handler. The handler repeats until no port has an interrupt pending. The card interrupt stays asserted while any port has one, so on an edge-triggered input a port that raised its interrupt while another port was serviced never got serviced and the card stopped receiving. QEMU docs/specs/pci-serial.rst, pci-serial-2x and pci-serial-4x: "Interrupt: Wired to pin A." Assisted-by: Claude:claude-opus-5-5 Signed-off-by: raiden00pl <raiden00@railab.me>
raiden00pl
requested review from
anchao,
jerpelea and
xiaoxiang781216
as code owners
November 18, 2026 18:17
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All ports of one PCI function of a multiport 16550 card share its
interrupt, but every port attached and enabled it on its own: opening a
second port replaced the handler of the first port, and closing a port
disabled the interrupt of the others.
interrupt pending.
and service all its ports in the handler until none has an interrupt
pending. The card interrupt stays asserted while any port has one, so on
an edge-triggered input a single pass left the card stuck.
Impact
Multiport PCI 16550 cards: all ports can be opened at the same time. Single
port cards are unchanged.
Testing
qemu-intel64, echo on all configured ports at the same time: