Repository navigation
PostgreSQL: Support FOR NO KEY UPDATE and FOR KEY SHARE - #2988
Open
LucaCappelletti94 wants to merge 2 commits into
Open
LucaCappelletti94 wants to merge 2 commits into
LucaCappelletti94 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2988 +/- ##
==========================================
+ Coverage 83.29% 83.30% +0.01%
==========================================
Files 42 42
Lines 35372 35381 +9
Branches 35372 35381 +9
==========================================
+ Hits 29463 29475 +12
+ Misses 2456 2453 -3
Partials 3453 3453 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MrBisonte
approved these changes
Nov 16, 2026
MrBisonte
left a comment
Contributor
There was a problem hiding this comment.
lgtm! How parse_lock reads the lock strength after this change:
FOR ─┬─ UPDATE ──────> Update
├─ SHARE ─────────> Share
├─ NO KEY UPDATE ──-> NoKeyUpdate new
└─ KEY SHARE ──────> KeyShare new
then [OF name] [NOWAIT | SKIP LOCKED]
Small follow up idea, not for this PR: OF only takes one name but Postgres allows a list so FOR UPDATE OF a, b still fails.
MrBisonte
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
NoKeyUpdateandKeyShare, read before the existingOF,NOWAITandSKIP LOCKEDhandling. LikeFOR UPDATEandFOR SHARE, they parse in every dialect.