Skip to content

Fix missing and unused local key for I18n - #1714

Open
hugueslamy wants to merge 1 commit into
aces:masterfrom
hugueslamy:master
Open

hugueslamy wants to merge 1 commit into
aces:masterfrom
hugueslamy:master

Conversation

@hugueslamy

Copy link
Copy Markdown

This fix combine the language yaml file and normalize them.
Also all the unused key are removed.
Some keys were not translated and were added in the appropriate locale.
Rework some ruby or erb code when the i18n-tasks was not able to resolve the interpolation.

@dlq

dlq commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

I tested c96874392 in English and French on an isolated Apple-container deployment (Ruby 2.7.8 / Rails 5.0.7.2).

  • Custom-filter validation. An invalid file size and an invalid task-description filter produced Translation missing in both languages with the base dictionaries. Both now return localized explanations. In French, Rails still prepends English field labels such as Data size term and Data description type.
  • Changed paths. Data-provider help rendered in both languages. The invalid IP-whitelist error interpolated the submitted value, and the invalid file-selection warning retained its HTML line break in both languages.
  • Earlier translation fixes. Chromium showed the localized upload buttons and both filename warnings, with submission disabled for invalid filenames. Blank message subjects and destinations still showed localized errors. API-token durations and the French task states Finie and Interrompue also passed. Rails loaded all 186 entries per language from 22 earlier-fix dictionaries with identical values, and Bourreau independently resolved the saved-work-directory messages in both languages.

I found no regressions in the earlier fixes I retested. The checks covered selected workflows and did not launch processing jobs. The missing Ongoing-tab introduction and two remaining English strings in the French file interface are tracked in #1660, along with the custom-filter field labels.

@dlq dlq mentioned this pull request Nov 12, 2026
1 of 6 tasks
@dlq

dlq commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Thanks, Hugues. My test comment mixed what #1714 fixes with gaps that were already present. Your PR adds the missing English and French custom-filter validation messages. I verified that invalid file sizes and task-description filters now show localized explanations in both languages. The earlier translation fixes I retested still passed.

Natacha already has #1711 open to restore the Ongoing-tab paragraph. The French custom-filter field labels, the “Large datasets?” link, and the compression skip reasons are tracked in #1660 for after Pierre’s v8 changes land. Those three items can wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants