Skip to content

Added the ability to run specific (optimization) passes to binaryen-c/.js - #1252

Merged
kripken merged 1 commit into
WebAssembly:masterfrom
dcodeIO:js-optimize-passes
Oct 30, 2017
Merged

kripken merged 1 commit into
WebAssembly:masterfrom
dcodeIO:js-optimize-passes

Conversation

@dcodeIO

@dcodeIO dcodeIO commented Oct 27, 2017 •

Copy link
Copy Markdown
Contributor

This PR adds a BinaryenModuleRunPasses function to the C-API respectively a runPasses method to the JS-API that takes an array of names of the passes to run.

Also fixes a couple of build issues with the JS binaries and includes the updated ones.

@dcodeIO
dcodeIO force-pushed the js-optimize-passes branch from b312296 to 3ee6593 Compare October 27, 2017 17:37
@kripken

kripken commented Oct 27, 2017

Copy link
Copy Markdown
Member

What do you think about adding a new API call alongside BinaryenModuleOptimize, something like BinaryenModuleRunPasses which receives a pass or passes to run? This both keeps backwards compatibility and also not all passes are optimization passes (although we do refer to them that way sometimes, but I feel that makes more sense internally than in an official API).

@dcodeIO

dcodeIO commented Oct 27, 2017

Copy link
Copy Markdown
Contributor Author

Sure, can do that as well!

@dcodeIO
dcodeIO force-pushed the js-optimize-passes branch from 3ee6593 to ba7d6c7 Compare October 27, 2017 20:31
@dcodeIO

dcodeIO commented Oct 27, 2017

Copy link
Copy Markdown
Contributor Author

Alright, updated the PR accordingly.

@dcodeIO dcodeIO changed the title Added the ability to run specific optimization passes to binaryen-c/.js Added the ability to run specific (optimization) passes to binaryen-c/.js Oct 27, 2017
@kripken

kripken commented Oct 30, 2017

Copy link
Copy Markdown
Member

Great, thanks!

@kripken
kripken merged commit 7a4c47e into WebAssembly:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants