Repository navigation
Track aliases reached through external dependencies - #643
Merged
tinder-maxwellelliott merged 1 commit intoNov 9, 2026
Merged
tinder-maxwellelliott merged 1 commit into
tinder-maxwellelliott merged 1 commit into
Conversation
When following a fine-grained external alias, deps() can return to another alias already in the primary query. Its duplicate row is discarded before bazel-diff reads the mapping from select conditions to destinations. Keep the name of each native alias reached in that query. Reread its actual attribute and apply it to the original row before hashing. Extend the Tinder#630 fixture with a filegroup that leads back into the hub. The build switches between two files whose labels stay in the input set. With a tags-only projection the alias and its consumer used to keep the same hash. A caller including Bazel's synthetic attribute fingerprint already detects this edit. Advance the cache and partial recipe versions so older alias hashes are regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A supplementary dependency query in #630 can follow an external alias into a filegroup and back to another alias in the original package. Bazel returns that second alias, but bazel-diff discards the duplicate row before reading its
actualbinding.The regression swaps two branches of a
select(). The build changes frombeforetootherwhile the set of dependency labels stays the same. With--proto:output_rule_attrs=tags, the alias and its consumer previously kept the same hashes. Callers that include Bazel’s synthetic attribute fingerprint already detect this particular edit.Record the native aliases reached by the dependency query and apply their evaluated bindings to the retained rows. Advance the cache and partial recipe versions so cached results also reflect the correction.
Assisted by Codex.