Repository navigation
Conversation
tinder-maxwellelliott
marked this pull request as ready for review
November 8, 2026 19:40
…ing them generate-hashes decoded every attribute of every queried rule (Bazel prints implicit ones too, dozens per rule), hashed each one by re-encoding it, and then dropped all of them except tags and visibility. Decoding, re-encoding and freeing those attributes was most of bazel-diff's own CPU in the query phase. The ordinary query path now walks each target's wire bytes, decodes the rule without the attributes only hashing reads, and hands those attributes to the prehash still encoded. The rule hash covers each attribute's message encoding, so hashing Bazel's bytes gives the same digest. Repository rules, cquery results, an isolated dependency root's strict query and anything the wire reader does not handle decode in full, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KJs3XzVMwWhwEiciBmHKk7
tinder-maxwellelliott
force-pushed
the
perf/lean-attribute-decode
branch
from
November 9, 2026 17:31
4bbe378 to
9c5616c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing them
generate-hashes decoded every attribute of every queried rule (Bazel prints implicit ones too, dozens per rule), hashed each one by re-encoding it, and then dropped all of them except tags and visibility. Decoding, re-encoding and freeing those attributes was most of bazel-diff's own CPU in the query phase.
The ordinary query path now walks each target's wire bytes, decodes the rule without the attributes only hashing reads, and hands those attributes to the prehash still encoded. The rule hash covers each attribute's message encoding, so hashing Bazel's bytes gives the same digest. Repository rules, cquery results, an isolated dependency root's strict query and anything the wire reader does not handle decode in full, as before.