How to check for system members? #198

Activity

1. x789 commented on Feb 28, 2023

   

   x789

   on Feb 28, 2023

   More actions

   I would also like to implement a test that only certain types can access the system time.
   However, the solution mentioned by @simonthum unfortunately does not work for me.

   I tried unsuccessfully with
   Classes().Should().NotCallAny(MethodMembers().That().AreDeclaredIn(typeof(System.DateTimeOffset)));

   However, this is reasonable to me since _ = DateTimeOffset.Now is an access to a property.
   However, I cannot replace MethodMembers with PropertyMembers because the result is not accepted by NotCallAny.

   I wonder if there is a way to check for property access, or is this functionality not (yet) part of ArchUnitNET?
2. x789 commented on Mar 2, 2023

   

   x789

   on Mar 2, 2023

   More actions

   I was wrong -- Properties are a C# feature which are transformed into methods by the compiler. After specifying an empty parameter list and adding the assembly of DateTimeOffset to the architecture, it worked:

   var rule = Types().That().ResideInAssembly(myAssembly).Should().NotCallAny("System.DateTimeOffset::get_Now()");

   I didn't find a way to define the rule strongly typed either. For the meantime I'm using an extension method. Maybe this is an acceptable workaround for others.

   // Extension method
   public static IArchRule NotAccessGetter<TType>(this ObjectsShould<TypesShouldConjunction, IType> builder, object? property, [CallerArgumentExpression("property")] string typeAndPropertyName = null!)
   {
     var names = typeAndPropertyName.Split('.');
     if (names[0] != typeof(TType).Name) throw new ArgumentException($"'{names[1]}' is not part of '{names[0]}'.");
   
     return builder.NotCallAny(MethodMembers().That().AreDeclaredIn(typeof(TType)).And().HaveName($"get_{names[1]}()"));
   }

   // Usage example
   [Fact]
   public void Test1()
   {
     // Remember to add the assembly that contains DateTimeOffset to your `architecture`.
     var types = Types().That().ResideInAssembly(myAssembly);
     types.Should().NotAccessGetter<DateTimeOffset>(DateTimeOffset.Now).Check(architecture);
     types.Should().NotAccessGetter<DateTimeOffset>(DateTimeOffset.UtcNow).Check(architecture);
   }

   👍React with 👍1Reacted by Victor Molostov
3. simonthum commented on Mar 20, 2023

   

   simonthum

   on Mar 20, 2023

   ContributorAuthor

   More actions

   @x789 I like that creative solution, although having to actually call the Property may make it difficult to use in some contexts.
4. alexanderlinne

   added

   kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.

   on Mar 22, 2024
5. alexanderlinne

   added

   waitforfeedback

   on Nov 28, 2025
6. alexanderlinne commented on Nov 28, 2025

   

   alexanderlinne

   on Nov 28, 2025

   Collaborator

   More actions

   Hi, is this still an issue?

   As far as I can see, since this issue has been opened, getting the property members should now be possible using PropertyMembers().That().AreDeclaredIn(typeof(DateTimeOffset)). But there does not seem to be a fluent method to check that Types().Should().NotAccessAny(PropertyMembers()...), so that may be missing?

   👍React with 👍1Reacted by AvremelM